Repository navigation
A switch case of another kind of primitive is an error - #586
Merged
Merged
Conversation
`switch (5) { case "a": ... }` compiled with no diagnostic: the switch's
value was cast to the case's type (the number became a string) and
compared. TypeScript rejects a case whose type is not comparable to the
switch's; tslang now rejects a case that is a number, string, boolean
or bigint when the switch is another of those, at the case expression,
with TypeScript's message. Unions, any, enums of mixed members and
other types are left as they were.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch (5) { case "a": ... }compiled with no diagnostic: the switch's value was cast to the case's type (the number became a string) and compared.Fix: a case whose type is a number, string, boolean or bigint (after literal and enum types) is an error when the switch's is another of those. It is reported at the case expression, with TypeScript's message. Unions,
any, mixed enums and other types are left alone.Repro (
diagnostic-location/switch_case_type.ts):ctest -C Release -j 8 --timeout 300: 100% passed, 0 failed (4092 tests on this branch).🤖 Generated with Claude Code