Repository navigation
An enum member after a string member needs an initializer - #588
Merged
Merged
Conversation
`enum E { A = "x", B }` compiled with no diagnostic, and B quietly
took the count of the members before it. TypeScript requires an
initializer there (a string has no next value); so does tslang now,
at the member. A member after a number member, a float one included,
still counts on from it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enum E { A = "x", B }compiled with no diagnostic, andBquietly took the count of the members before it.Fix: a member without an initializer after a string member is an error at the member (TypeScript's TS1061). A member after a number member, including a float one (
A = 1.5, B), still counts on.Repro (
diagnostic-location/enum_member_initializer.ts):ctest -C Release -j 8 --timeout 300: 100% passed, 0 failed (4092 tests on this branch).🤖 Generated with Claude Code