Skip to content

Borrow facts: name the symbol after the module's own file (JIT cache duplicate symbol) #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ASDAlexander77 merged 2 commits into from
Oct 20, 2026
Merged

Borrow facts: name the symbol after the module's own file (JIT cache duplicate symbol) #628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
242f5f3
Borrow facts: name the symbol after the module's own file
ASDAlexander77 Oct 20, 2026
5618e46
Borrow facts: not exported from the modules the JIT cache compiles
ASDAlexander77 Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions tslang/tslang/transform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,21 @@ int runMLIRPasses(mlir::MLIRContext &context, llvm::SourceMgr &sourceMgr, mlir::
}

// What this module promises importers about its parameters, whether or not it promotes
// anything itself. Nothing imports a JIT-run program.
if (!compileOptions.isJit && !noBorrowFactsExport)
// anything itself. Nothing imports a JIT-run program, nor the modules the JIT cache
// compiles beside it (isJit off, jitCache on): their objects are only loaded into the
// JIT, never linked, and the program run there does not read facts from them
// (StackPromotionPass). Named after the module's own file, the main buffer, not
// inputFilename, so a symbol is never another module's.
if (!compileOptions.isJit && !compileOptions.jitCache && !noBorrowFactsExport)
{
llvm::StringRef moduleFile = inputFilename;
if (sourceMgr.getNumBuffers() > 0 && inputFilename != "-")
{
moduleFile = sourceMgr.getMemoryBuffer(sourceMgr.getMainFileID())->getBufferIdentifier();
}

pm.addPass(mlir::typescript::createBorrowFactsExportPass(
SHARED_LIB_BORROW_FACTS + typescript::moduleSymbolSuffix(inputFilename)));
SHARED_LIB_BORROW_FACTS + typescript::moduleSymbolSuffix(moduleFile)));
}

// Under every model, after own's inference: what it decides about a stack object's retains
Expand Down
Loading