Repository navigation
Release 0.2.0 - #5
Merged
Merged
Conversation
Raise pascalscript to 0.2.0. innospect re-exports it as innospect::pascalscript, so its breaking API changes make this a minor release. Also raise lzma-rust2 to 0.21 and encoding_rs to 0.8.42. Build every test fixture from a script under Wine in Docker, replacing the Windows build host and the third-party HeidiSQL and ImageMagick samples with full.iss (Inno Setup 6.4.0 and 6.1.0) and adding code.iss. Commit the fixtures and make the integration tests fail on a missing one instead of skipping, with a test that checks the committed set against build/versions.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pascalscriptto 0.2.0. innospect re-exports it asinnospect::pascalscript, so its API changes (removedProcDisasm::branch_target(s),FlagGoto's field renamedoffset,SetStackPointerToCopy { dest, src }) reach callers. Hence 0.2.0 rather than 0.1.5.lzma-rust20.18 -> 0.21 (no source changes; drops themultiversiontransitive dep) andencoding_rs0.8.41 -> 0.8.42. All other direct dependencies are already at their latest releases.tests/samples/build/build-wine.sh, matrix inversions.txt), replacing the Windows build host. The third-party HeidiSQL / ImageMagick samples are replaced byfull.iss(built with 6.4.0 and 6.1.0), andcode.issadds a compiled[Code]fixture with branch-target and stack-frame tests.sample()/samples_in()now fail instead of skipping, the encrypted walker requires both euFiles and euFull samples, and the newevery_matrix_fixture_is_presenttest checks the committed set againstversions.txt(missing or unexpected fixtures both fail).See
CHANGELOG.mdfor the full entry.Verification
On a fresh clone of this branch, resolving every dependency from crates.io:
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningsRUSTDOCFLAGS=-D warnings cargo doc --no-deps --all-featurescargo teston stable and on the 1.88 MSRV: 80 unit, 9 integration, 1 doc testfull/full-tool6_1_0.exehidden,full_6_1_0_identifiesandevery_matrix_fixture_is_presentfail; with a strayplain/*.exeadded,every_matrix_fixture_is_presentfails.