Repository navigation
fix(public-links): copy and show an absolute public link URL when FRONTEND_URL is unset (#3170) - #3171
Merged
Conversation
…NTEND_URL is unset (#3170) The backend builds a public link's `url` as `${FRONTEND_URL}/chat/<token>`, and FRONTEND_URL defaults to empty, so the Sharing panel showed and copied a bare `/chat/<token>` path. Resolve it against the page origin in the panel. An absolute `url` or `external_url` passes through unchanged. Closes #3170 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
FRONTEND_URLunset (the.env.exampledefault) the backend returns a public link'surlas/chat/<token>, and the Sharing → Public links panel showed and copied that bare path.utils/publicLinkUrl.js:external_url || url, resolved againstwindow.location.originwithnew URL(). Absolute URLs pass through unchanged.PublicLinksPanel.vueuses it for both the displayed link and the Copy button.Test plan
tests/unit/publicLinkUrl.spec.js: relative path resolved, absoluteurlkept,external_urlpreferred, empty link →''. Failed before the helper existed, passes now.Closes #3170
🤖 Generated with Claude Code