Repository navigation
fix(codex): require status context for numeric rate-limit errors - #3176
Merged
vybe merged 2 commits intoOct 2, 2026
Merged
Conversation
`\s*[:=]?\s*` lets the two adjacent `\s*` split a run of whitespace every way, so classification was quadratic in stderr length (~47s on 200k spaces, inline on the agent server's event loop). `\s*(?:[:=]\s*)?` matches the same strings in linear time. merge-train: mechanical, per the merge-train note on the PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
merge-train: pushed
The validation also raised two non-blocking points, for you to consider:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3175
A failed Codex turn containing
.429Zin a timestamp orlocalhost:4299currently becomes HTTP 429 because the classifier searches for bare429. Require recognizable HTTP/status context for numeric 429; keep existing named rate/quota markers and authentication behavior.The two-file change adds real-function regression cases for incidental timestamps, process IDs, ports and 4290, with preservation cases for HTTP/status 429, named errors and authentication. Against official dev
12cb5f9, the focused suite produced 9 failures and 26 passes before the fix; all 35 pass afterward. A separate independent parser-to-classifier harness produced 3 incidental-digit failures and 10 preservation passes on stock, then 13 passes after the fix.Validation used Python 3.12 and the real runtime module in an isolated unit harness; no provider calls or production services. Full unit suite, base-image build and live CLI integration were not run. Independent adversarial review found no blocking issue within this numeric-matching scope. Competing terminal/stderr precedence and broader structured-error handling are unchanged.