Repository navigation
test(portal): pin now in the background-ask Inbox spec (date rot) - #3348
Merged
Merged
Conversation
…e aged out of the 7-day window `allItems` keeps an ended ask for ENDED_ASK_WINDOW_DAYS against the wall clock, and the spec's ENDED fixture is dated 2026-09-30, so from 2026-10-07 the "All keeps it once it ended" case fails on dev and on every PR that runs the frontend build. Pass `now` beside the fixture, as allItems already allows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
vybe
approved these changes
Oct 7, 2026
vybe
left a comment
vybe
left a comment
Contributor
There was a problem hiding this comment.
merge-train: date-rot prerequisite, merged alone ahead of the batch
9 tasks done
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portalBackgroundAskInboxOnly.spec.js› "Action lists it while it waits; All keeps it once it ended" fails from 2026-10-07 ondevand on every PR that runs the frontendbuild:allItemskeeps an ended ask forENDED_ASK_WINDOW_DAYS(7) measured fromDate.now(), and theENDEDfixture is dated2026-09-30T11:00:00Z.The fix passes
nowbeside the fixture (allItemsalready takes it). Same edit as in #3332, which is held for an unrelated finding, so it ships alone ahead of the merge train.No issue: a dated fixture crossing its window, found by the merge train (#3345's
buildfailed on it, reproduced on cleanorigin/dev).🤖 Generated with Claude Code