Repository navigation
chore: set version to 1.0.0-rc3 - #3650
Conversation
VERSION and the DigitalOcean create script's default image tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dolho
left a comment
There was a problem hiding this comment.
/review on 007b4c778: approve
Scope: clean. Two lines, both exactly as described: VERSION 1.0.0-rc2 → 1.0.0-rc3, and trinity-do-create.sh's TRINITY_IMAGE_TAG default v1.0.0-rc2 → v1.0.0-rc3. The branch is 1 commit ahead of dev, 0 behind.
Claims verified:
- Pin guard:
tests/unit/test_2380_installer_release_pin.pygives 2 passed locally (it ties the installer default toVERSION). lateststays put:publish-images.yml:200istype=raw,value=latest,enable=${{ … startsWith(github.ref, 'refs/tags/v') && !contains(github.ref_name, '-') }}, plusflavor: latest=false. So thev1.0.0-rc3tag publishesv1.0.0-rc3/1.0.0-rc3only, and hosted installs onlatestdon't move.- Enterprise pin:
src/backend/enterpriseon this branch isf8d1d3cf8, which is enterprisemain. No pointer bump needed. - Open P0s: #3106, #3012 and ent#849, all
status-in-dev. None is outside in-dev, as stated. - Tag:
v1.0.0-rc3doesn't exist yet, so nothing collides.
One note for RC3's scope (not a blocker for this PR): ent#849 is labelled status-in-dev, but its enforcement isn't in RC3. The public seam (#3428) is on dev, but the enterprise provider is ent PR #853, which is still open, and the pinned enterprise commit f8d1d3c has no email_code_allowed. With no provider registered, login_policy_gate allows every code through. So on RC3, unchecking "Keep email-code sign-in available for users" still changes nothing. Either:
- release-note it, or move ent#849 back to in-progress until #853 merges and the pointer is bumped; or
- merge #853 and bump the pointer before tagging, if it's meant to be in this RC.
Whoever re-tests the SSO row on RC3 should expect the old behaviour.
CI: 9 passed, 6 still pending at review time. Tag once they're green.
🤖 Generated with Claude Code
Summary
Sets
VERSIONand the DigitalOcean create script's default image tag to1.0.0-rc3, ahead of taggingv1.0.0-rc3ondev.VERSION:1.0.0-rc2→1.0.0-rc3scripts/deploy/trinity-do-create.sh:TRINITY_IMAGE_TAGdefaultv1.0.0-rc2→v1.0.0-rc3(pinned toVERSIONbytests/unit/test_2380_installer_release_pin.py)Release-candidate scope
devtip after this merges.mainis untouched and there is no release PR.status-in-devlabels change.publish-images.ymlpublishesv1.0.0-rc3and1.0.0-rc3to GHCR.lateststays where it is: thetype=raw,value=latestentry carries!contains(github.ref_name, '-').Pre-release checks
devsincev1.0.0-rc2.status-in-dev.v1.0.0-rc2..dev: clean.f8d1d3cequals enterprisemain; no pointer bump needed.Test plan
tests/unit/test_2380_installer_release_pin.py: 2 passed🤖 Generated with Claude Code