Skip to content

test(analytics): gap-fill day-stack test picks the seeded day, not timeline[-1] (dev-ci red #3689) - #3690

Merged
vybe merged 1 commit into
devfrom
fix/analytics-gapfill-midnight-flake
Oct 14, 2026
Merged

vybe merged 1 commit into
devfrom
fix/analytics-gapfill-midnight-flake

Conversation

@trinity-ability

Copy link
Copy Markdown
Contributor

Why

dev-ci went red at aca0a01e (2026-10-14 00:17 UTC) on exactly one test out of 26,650: tests/unit/test_agent_analytics.py::TestTimelineGapFill::test_day_stacks_present_in_by_type — assert None == 1.

The test seeds three executions at _iso_ago(hours=1) and asserts they stack in out["timeline"][-1] (today). Between 00:00 and 01:00 UTC "an hour ago" is yesterday, so today's point is empty. It is wall-clock rot, not a regression: the test is unchanged since v0.7.0 (last touched by #1693), none of the five commits since dev-green touch analytics, and it reproduces locally on plain dev inside the window (3/3 runs) and passes outside it.

What

Select the timeline point whose date equals the seeded started_at[:10] instead of [-1]. Test-only change.

Verified

Fixes #3689

🤖 Generated with Claude Code

…meline[-1]

Between 00:00 and 01:00 UTC the executions seeded 'an hour ago' fall on
yesterday's bucket, so the last timeline point (today) is empty and the
test fails with 'assert None == 1'. It took dev-ci red at aca0a01 on
2026-10-14 00:17 UTC with every other test green; the test has been this
shape since v0.7.0. Select the point whose date matches the seeded
started_at instead.

Fixes #3689

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@vybe vybe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-train (2026-10-14): red-dev fix for #3689 — wall-clock flake, test-only, reproduced inside the 00:00–01:00 UTC window and verified fixed there.

@vybe
vybe merged commit c5d3272 into dev Oct 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants