Repository navigation
test(analytics): gap-fill day-stack test picks the seeded day, not timeline[-1] (dev-ci red #3689) - #3690
Merged
Conversation
…meline[-1] Between 00:00 and 01:00 UTC the executions seeded 'an hour ago' fall on yesterday's bucket, so the last timeline point (today) is empty and the test fails with 'assert None == 1'. It took dev-ci red at aca0a01 on 2026-10-14 00:17 UTC with every other test green; the test has been this shape since v0.7.0. Select the point whose date matches the seeded started_at instead. Fixes #3689 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dev-ciwent red ataca0a01e(2026-10-14 00:17 UTC) on exactly one test out of 26,650:tests/unit/test_agent_analytics.py::TestTimelineGapFill::test_day_stacks_present_in_by_type—assert None == 1.The test seeds three executions at
_iso_ago(hours=1)and asserts they stack inout["timeline"][-1](today). Between 00:00 and 01:00 UTC "an hour ago" is yesterday, so today's point is empty. It is wall-clock rot, not a regression: the test is unchanged since v0.7.0 (last touched by #1693), none of the five commits sincedev-greentouch analytics, and it reproduces locally on plaindevinside the window (3/3 runs) and passes outside it.What
Select the timeline point whose
dateequals the seededstarted_at[:10]instead of[-1]. Test-only change.Verified
tests/unit/test_agent_analytics.py13 passed, twice.Fixes #3689
🤖 Generated with Claude Code