[vybe]

Summary

The agent page gets one configuration home: a Settings tab pinned at the end of the strip, with a left rail of panes (General · Guardrails · People · Channels · Integrations · Storage), a "Find a setting" box, and one restart banner that names every change waiting for a restart. The Info, Credentials, Access and Folders tabs are gone; the header is down to identity, state, the autonomy chip and the doors.

Implements (private tracker; closed manually at release):

• abilityai/trinity-enterprise#887 — rail, General pane, one restart banner; includes the execution-timeout control (abilityai/trinity-enterprise#353)
• abilityai/trinity-enterprise#890 — Guardrails (hosts the self-change toggles from abilityai/trinity-enterprise#756; the autonomy dial is shown read-only until feat(workspace): the autonomy dial — what a companion may do unprompted (ent#641) #2984 merges)
• abilityai/trinity-enterprise#888 — Storage (removes the Credentials and Folders tabs, takes configuration out of the Git tab)
• abilityai/trinity-enterprise#891 — People (the Access tab, unchanged; feat(access): who an agent serves, its seat, and what reads it (abilityai/trinity-enterprise#810–#814, #817) #3271, feat(auth): the user role is Workspace-only; sharing stops creating logins (abilityai/trinity-enterprise#837) #3488 and feat(access): the platform role on the Access tab; a user assigned to a companion answers its asks (abilityai/trinity-enterprise#837) #3634 have merged)

What's in each pane

• General — identity (label, id rename, avatar + next emotion, template description, tags), runtime / model / funding, execution timeout (1–120 min, named errors, agent_timeout_below_active_schedules → "Open Schedules"), parallel capacity (names the clamp when stored > ceiling), read-only mode, memory & CPU (with "Inherit default"; saved now, applied by the banner's restart — no longer restarts the agent on save), template technical details in a dialog, Danger zone (reset to main only when a repo is bound; delete).
• Guardrails — rules (behind "Manage rules"), self-change permissions, approval-gated skills count → Skills, autonomy (read-only), cross-model validation (entitled), reliability.
• People — AccessPanel embedded, unchanged.
• Channels / Integrations — the Voice and MCP cards from the old Settings list, plus rows that open the tabs that still hold the rest.
• Storage — repository binding, GitHub token, auto-sync, credentials, shared folders, file sharing.
• Git tab keeps the operational half, and gains Pull / Push / Refresh (they lived only in the header).
• Overview gains AgentLiveStrip (live CPU/memory, spend, created date) from the header.

Deep links keep working: ?tab=info|guardrails|credentials|folders|access resolve to their pane; the pane is in the URL (?section=), so Back steps between panes.

Decisions (confirmed with the operator)

• Settings is owner-only; shared operators no longer see the Info/Credentials views (they keep Overview's description).
• The system agent gets General (read-only identity/limits), Guardrails and Integrations.
• People is shown without the user-management entitlement because it carries OSS sharing.
• The description is read from the template until a shared editable one exists (abilityai/trinity-enterprise#584).

Restart banner

Rows report into stores/agentRestart.js; the banner lists them and offers Restart (or Start for a stopped agent). The list settles on the agent's real stopped → running status edge, not on the button: a start that fails keeps every entry listed, and a manual stop/start from the header settles it too.

Tests

Red first, then green:

• tests/unit/agentSettingsHome.spec.js — strip, alias resolution, pane visibility, search, restart registry
• tests/unit/agentSettingsHome.mount.spec.js — rail navigation through the URL, banner, timeout validation/save/conflict, inherit-default, ceiling note
• tests/unit/agentSettingsRestart.mount.spec.js — failed start keeps the list; success and manual start settle it
• tests/unit/fileSharingPanelAudience.spec.js — reports to the banner; agent switch never carries a wait over

Against dev: 13 assertions fail on the missing behaviour. On the branch: 379 files / 6,048 tests pass, check:tokens OK, raw-colour and loading-gate ratchets pass (AgentHeader 132 → 9 raw colour classes), build OK. Visual pass with Playwright in light/dark at 1440 and 390 on a running and a stopped (git-bound) agent: no console errors, no overflow.

Docs

docs/memory/feature-flows/agent-settings-home.md (new), requirements/core-agent.md §1.6–1.7, architecture/frontend.md, and the user docs that named the retired tabs.

🤖 Generated with Claude Code

[dolho]

/review — automated pre-landing review (at refs/pull/3798/head)

Branch: feature/887-agent-settings-home → dev (merge-base 93b57e43d)
Files Changed: 64 (+3076/−1559), frontend plus docs, no backend change
Scope: CLEAN. The diff stays on the Settings home, the retired tabs' redirects and the restart banner. The header slimming and the Git tab's Pull/Push are in the PR description.
Plan Completion: no plan file; the private-tracker issues were not fetched. The four listed panes (General, Guardrails, People, Storage) plus Channels/Integrations are all in the diff.

Execution coverage

changed symbol	executed by	live consumer	verdict
agentRestart.js store, settleRestart, restartForPendingChanges (AgentDetail.vue)	agentSettingsRestart.mount.spec.js mounts the real AgentDetail over a fake backend: failed start keeps the list, start clears it, header start settles it	SettingsRestartBanner.vue, GitHubAuthRow.vue, GuardrailsPane.vue	✅ executed
agentSettings.js (resolveSettingsSection, filterSections), agentTabs.js aliases	agentSettingsHome.spec.js + mount spec	AgentSettingsHome.vue, AgentDetail.vue	✅ executed
executionTimeout.js, GeneralPane timeout row	mount spec: range refusal, minutes→seconds, schedule conflict	GeneralPane.vue	✅ executed
Memory/CPU row + saveResourceLimits	mount spec covers "Inherit default" saving null	GeneralPane.vue	✅ for the happy path. ❌ nothing drives a failed save or failed reload (see I2)
test_1712_circuit_breaker_honest_toggle.py	reads GuardrailsPane.vue text for <ReliabilityPanel	CI only	🛡 guard, but source text over a .vue (see appendix)

This is a feature PR, so the fix-mutation rule does not apply.

Critical findings

None.

Informational findings

[I1] Documentation staleness: three feature flows still describe deleted files (Confidence: 8/10)
Evidence: ResourceModal.vue and components/settings/SettingsPanel.vue no longer exist on the branch, yet:

• docs/memory/feature-flows/agent-guardrails.md:40,160,190,193,323 describes SettingsPanel.vue as the tab container, with line numbers.
• docs/memory/feature-flows/agent-mcp-key.md:25 says the key panel is "an additive section in settings/SettingsPanel.vue".
• docs/memory/feature-flows/agent-resource-allocation.md:55,56 documents the ResourceModal import and usage.

Suggestion: run /sync-feature-flows over these three. agent-resource-allocation.md also needs the new behaviour: saving no longer restarts the agent, and the change joins the banner.

[I2] Memory/CPU row dead-ends on a load error (Confidence: 7/10)
File: src/frontend/src/components/agent-settings/GeneralPane.vue:256,262
Evidence: <span v-if="resourceLimits.error" …>Couldn't load the limits.</span> and v-if="canEdit && !resourceLimits.error && editing !== 'resources'" on Edit.
Issue: saveResourceLimits (AgentDetail.vue) always calls loadResourceLimits() after a save, including a failed one. If that reload fails, error is set, Edit disappears, and there is no retry. loadAll in the pane never re-reads limits, so only a page reload or a restart settle clears it. The Storage repository row, in the same PR, does offer "Try again".
Suggestion: add a "Try again" button on the error branch that calls the load, as the repository row does. Add a mount test for a failed save followed by a failed reload.

[I3] Stale comment points at a deleted component (Confidence: 8/10)
File: src/frontend/src/composables/useAgentSettings.js:93
Evidence: // The ResourceModal renders resourceLimits.error as a banner. The modal is deleted and nothing renders a banner now (see I2).
Suggestion: update the comment when fixing I2.

Clean categories

• SQL / auth / credentials / enterprise disclosure: frontend and docs only. The Settings tab stays gated on agent.can_share, and the pane contents are rendered under v-if="activeTab === 'settings' && agent.can_share" (AgentDetail.vue). No credential values are logged or shown. The added docs name no private modules.
• Deep links: the aliases info, credentials, folders and access all resolve through TAB_ALIASES + LEGACY_TAB_SECTIONS. The one remaining in-app emitter, OverviewPanel.vue:301, is now v-if="agent.can_share", so a shared operator gets no dead "Full details" link. No backend or MCP code builds ?tab=info|credentials|folders|access URLs (grepped src/backend, src/mcp-server).
• Restart banner: the status-edge watcher guards name !== prevName and a falsy prevStatus, so loading an agent or switching agents does not settle. A failed start leaves every entry listed (mount spec).
• Resources semantics: pending is computed against the container labels (agent_config.py current_memory/current_cpu), which are what check_resource_limits_match recreates on. Clearing an override reports no pending, matching the backend's db_limits.get(...) or current rule. The old modal had the same "Inherit default" behaviour, so this is not a regression.
• Ratchets: raw-colour and loading-gate baselines only shrink (AgentHeader 132 → 9, plus the deleted ResourceModal/SettingsPanel/CapacityPanel entries).

Low confidence (appendix)

• agentDetailTalkDoor.spec.js drops expect(HEADER_RAW).toContain('target="_blank"'). That line proved the "talk door has no _blank" check wasn't vacuous. The Git row it relied on moved out of the header, so the cross-check can no longer hold as written. Consider asserting the scoped slice is non-empty instead (4/10).
• test_1712_… asserts "<ReliabilityPanel" in <GuardrailsPane.vue text>. It is the existing pattern, but a mount of GuardrailsPane would prove the panel renders (4/10).

Summary

• Critical: 0, nothing blocks the merge.
• Informational: 3 (I1 docs, I2 error dead-end, I3 stale comment).
• Scope: clean.

I read the diff and the new panes and specs. I did not run the vitest suite or the UI.

[github-actions]

⚠️ Live-instance suite skipped — merge conflict against dev.

Resolve by merging dev locally and pushing the result; the next nightly re-tests.

[trinity-ability]

Validated via /validate-pr: Lane B, Tier 1 green on 9720dde, dev green. /review informational findings (stale feature flows, GeneralPane resource-limits retry, stale comment) tracked as follow-up.