Repository navigation
fix(ui): point personal GitHub token messages at Settings → MCP Keys (abilityai/trinity#3543) - #3898
Merged
Merged
Conversation
…3543) Five messages sent users to "Settings → GitHub token", which does not exist. The saved personal token lives in the "Personal GitHub Token" card on the MCP Keys tab. Backend and frontend now name that location, and a unit test checks the wording against the labels Settings renders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e saved-token line (#3543) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
/review + /validate-prVerdict: APPROVE. No critical findings. Lane B, no schema change. Review
Fixed after review
Validate: commits, base Open: the manual Bind-repo check in the test plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FORK_PAT_REQUIRED, saved-token failure) and frontend (saved-token line, Bind repo and fork-to-own missing-token errors) use the same wording.Settings.vueand the card heading fromUserGitHubPatPanel.vue, so renaming either fails CI.Changes
src/backend/services/agent_service/fork_to_own.pysrc/frontend/src/components/{SavedGithubTokenField,BindRepoPanel,CreateAgentModal}.vuesrc/frontend/tests/unit/savedGithubToken.mount.spec.js(two pins updated)tests/unit/test_3543_personal_token_location.py(new)docs/memory/requirements/github.md,docs/memory/feature-flows/github-import-intents.md(same string)Test Plan
cd tests && pytest unit/test_3543_personal_token_location.py unit/test_3164_fork_uses_saved_pat.py— 24 passed (new test was red on 4 of 5 before the fix)npx vitest run tests/unit/savedGithubToken.mount.spec.js tests/unit/rawColorRatchet.spec.js— 23 passedFixes #3543
🤖 Generated with Claude Code