Skip to content

fix(ui): point personal GitHub token messages at Settings → MCP Keys (abilityai/trinity#3543) - #3898

Merged
vybe merged 2 commits into
devfrom
feature/3543-github-token-location
Oct 23, 2026
Merged

vybe merged 2 commits into
devfrom
feature/3543-github-token-location

Conversation

@obasilakis

@obasilakis obasilakis commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Five user-facing messages sent users to "Settings → GitHub token", which does not exist. They now say Settings → MCP Keys → Personal GitHub Token, the tab and card labels Settings renders.
  • Backend (FORK_PAT_REQUIRED, saved-token failure) and frontend (saved-token line, Bind repo and fork-to-own missing-token errors) use the same wording.
  • A unit test reads the tab label from Settings.vue and the card heading from UserGitHubPatPanel.vue, so renaming either fails CI.

Changes

  • src/backend/services/agent_service/fork_to_own.py
  • src/frontend/src/components/{SavedGithubTokenField,BindRepoPanel,CreateAgentModal}.vue
  • src/frontend/tests/unit/savedGithubToken.mount.spec.js (two pins updated)
  • tests/unit/test_3543_personal_token_location.py (new)
  • docs/memory/requirements/github.md, docs/memory/feature-flows/github-import-intents.md (same string)

Test Plan

  • cd tests && pytest unit/test_3543_personal_token_location.py unit/test_3164_fork_uses_saved_pat.py — 24 passed (new test was red on 4 of 5 before the fix)
  • npx vitest run tests/unit/savedGithubToken.mount.spec.js tests/unit/rawColorRatchet.spec.js — 23 passed
  • Manual: Bind repo with no token saved, message names MCP Keys → Personal GitHub Token

Fixes #3543

🤖 Generated with Claude Code

…3543)

Five messages sent users to "Settings → GitHub token", which does not
exist. The saved personal token lives in the "Personal GitHub Token" card
on the MCP Keys tab. Backend and frontend now name that location, and a
unit test checks the wording against the labels Settings renders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@obasilakis obasilakis added the ui PR touches the frontend UI — triggers Playwright e2e tests label Oct 22, 2026
…e saved-token line (#3543)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@obasilakis

Copy link
Copy Markdown
Contributor Author

/review + /validate-pr

Verdict: APPROVE. No critical findings. Lane B, no schema change.

Review

  • Scope clean. All three acceptance criteria met: the five messages name Settings → MCP Keys → Personal GitHub Token, backend and frontend use the same wording, and the two spec assertions are updated.
  • The location exists for every user: the MCP Keys tab is adminOnly: false and renders UserGitHubPatPanel, heading "Personal GitHub Token".
  • Mutation: restoring the dev strings turns 4/5 new pytest cases and 2/9 mount tests red; renaming the tab label fails test_location_matches_the_rendered_settings_labels.

Fixed after review

  • Two code comments (fork_to_own.py, routers/git.py) still named the old location.
  • The github-token-saved line's text is now asserted on the mounted component.

Validate: commits, base dev, size, closing keyword, security greps, file modes all ✅. CI green at review time.

Open: the manual Bind-repo check in the test plan.

@vybe vybe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-train: batch validated on train/20261023-2211 (#3930, all checks green)

@vybe
vybe merged commit cb3e43b into dev Oct 23, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui PR touches the frontend UI — triggers Playwright e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants