Repository navigation
fix(ui): chat file picker offers ZIP files (abilityai/trinity#2749) - #3899
Merged
Merged
Conversation
The upload service accepts ZIP (stored as-is), but the Chat tab's paperclip picker filtered it out, so a ZIP could only be dropped onto the input. Add .zip / application/zip to the picker's accept list and drop the workaround from the user doc. The Workspace composer's picker has no accept filter, so it already offers ZIP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
obasilakis
added
the
ui
The source-text ratchet holds a new spec to zero reads of component source. Mount ChatInput and assert on the rendered file input's accept list instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
Contributor
Author
/review + /validate-prVerdict: APPROVE after fixes (review asked for light changes; fixed below). No critical findings. Lane B. Review
Fixed after review
Follow-up filed: #3908 — a ZIP declared as Open: the manual picker check in the test plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.zip/application/zip. The upload service already accepts ZIP and stores it unextracted; the path, limits and storage are unchanged.PortalConversation.vue,PortalRailFiles.vue) set noacceptfilter, so they already offer ZIP. No change there.docs/user-docs/agents/agent-chat.mddrops the "drop a ZIP onto the input instead" caveat.Changes
src/frontend/src/components/chat/ChatInput.vue(accept list)src/frontend/tests/unit/chatPickerZip.spec.js(new)docs/user-docs/agents/agent-chat.mdTest Plan
npx vitest run tests/unit/chatPickerZip.spec.js tests/unit/turnCancel.spec.js tests/unit/agentDetailTalkDoor.spec.js— 70 passed (new spec red before the fix).zipis selectable and uploads like a dropped oneFixes #2749
🤖 Generated with Claude Code