Repository navigation
fix: allow list, pause/off, custom filters and blocked counter - #13
Merged
Merged
Conversation
- allow list: match the navigation itself (requestDomains + main_frame) instead of initiatorDomains, which never matched a directly opened page; cosmetic filtering now honours the allow list and the pause - pause/off: custom filters are dynamic rules that ignored the ruleset toggle and kept blocking; they are now removed/re-added with it - custom filters: bare domains and URLs become ||host^, invalid lines are dropped and reported in the dashboard instead of failing the whole update (capped at Chrome's 5000 unsafe dynamic rules) - counter: onRuleMatchedDebug was never available (no feedback permission), so the total only counted cosmetic hides on each load. Use Chrome's native per-tab action count for the badge and getMatchedRules (activeTab) in the popup; drop the dead total and top-domains views and their stored keys
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs corrigés
Reproduits sur
maindans Chromium 152 sans interface, avec l'extension chargée :initiatorDomainsne correspond jamais à une page ouverte directementupdateDynamicRulesé→ rien appliqué, anciennes règles gardées||host^onRuleMatchedDebugn'a jamais existé (pas de permission feedback)getMatchedRulesde la page (activeTab)Le total et le « Top domaines bloqués » sont supprimés : sans
declarativeNetRequestFeedback(avertissement « lire l'historique »), l'extension ne peut pas les connaître. Les cléscount/domainStatssont nettoyées à la mise à jour.Tests
Banc CDP sur Chromium 152 : 17/17 (blocage par défaut, badge natif, liste blanche réseau + cosmétique, normalisation et rejet des filtres, OFF, ON, pause, popup, dashboard, aucune erreur console).
À valider à la main : clic sur l'icône → nombre de la page affiché dans le popup (le banc ne peut pas accorder activeTab).