Repository navigation
removing hard-coded confluent kafka version and supplying it from requirements file - #245
Merged
Merged
Conversation
lsulak
requested review from
oto-macenauer-absa,
petr-pokorny-absa and
tmikula-dev
as code owners
October 21, 2026 08:47
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
Restore librdkafka compilation and installation before building confluent-kafka from source.
1 open issue
What changed in this PR
This PR addresses the Docker build failure reported in #244 by deriving the native librdkafka version from the Python dependency pin.
Changes:
- Reads the confluent-kafka version from
requirements.txt. - Uses that version for the librdkafka download and extraction paths.
| File | Description |
|---|---|
| Dockerfile | Replaces the hard-coded librdkafka version with the requirements pin, but also removes compilation and installation. |
Review effort: Balanced
tmikula-dev
previously approved these changes
Oct 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tmikula-dev
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
as the title says
Release Notes
Related
Closes #244