Skip to content

[testrender] Enable mipmap in optix by switching to cached ImageBuf - #2155

Open
AlexeySmolenchuk wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
AlexeySmolenchuk:enable-mipmaps-in-optix
Open

[testrender] Enable mipmap in optix by switching to cached ImageBuf#2155
AlexeySmolenchuk wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
AlexeySmolenchuk:enable-mipmaps-in-optix

Conversation

@AlexeySmolenchuk

Copy link
Copy Markdown
Contributor

Description

This PR workarounds this issue

I also increased maxAnisotropy to the maximum to prevent overblurring and match CPU results better.

Tests

Expect some Optix tests may fail.

Checklist:

  • I have read the guidelines on contributions and code review procedures.
  • I have read the Policy on AI Coding Assistants
    and if I used AI coding assistants, I have an Assisted-by: TOOL / MODEL
    line in the pull request description above.
  • I have updated the documentation if my PR adds features or changes
    behavior.
  • I am sure that this PR's changes are tested in the testsuite.
  • I have run and passed the testsuite in CI before submitting the
    PR, by pushing the changes to my fork and seeing that the automated CI
    passed there. (Exceptions: If most tests pass and you can't figure out why
    the remaining ones fail, it's ok to submit the PR and ask for help. Or if
    any failures seem entirely unrelated to your change; sometimes things break
    on the GitHub runners.)
  • My code follows the prevailing code style of this project and I
    fixed any problems reported by the clang-format CI test.

… ImageBuf

Signed-off-by: Alexey Smolenchuk <alexey.smolenchuk@gmail.com>
@AlexeySmolenchuk
AlexeySmolenchuk marked this pull request as ready for review August 27, 2026 13:31
@lgritz

lgritz commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

I think something is going wrong, see the logs in the failing optix version.

@AlexeySmolenchuk

Copy link
Copy Markdown
Contributor Author

Turns out the cached version is also buggy.
I've updated OIIO issue.
I'll replace it with a more reliable seek_subimage()

@AlexeySmolenchuk
AlexeySmolenchuk marked this pull request as draft August 28, 2026 11:30
Signed-off-by: Alexey Smolenchuk <alexey.smolenchuk@gmail.com>
Signed-off-by: Alexey Smolenchuk <alexey.smolenchuk@gmail.com>
@AlexeySmolenchuk

AlexeySmolenchuk commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author
Test
render-background Hdri image now filtered anisotropically
render-raytypes Hdri image now filtered anisotropically
testoptix-noise Seems refimage for gabor noise is outdated. It doesn't match even without this commit.
render-spi-thinlayer I can see "an illegal memory access" error in all recent CI, even successful

@AlexeySmolenchuk
AlexeySmolenchuk marked this pull request as ready for review August 28, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants