[testrender] Enable mipmap in optix by switching to cached ImageBuf - #2155
Open
AlexeySmolenchuk wants to merge 3 commits into
Open
[testrender] Enable mipmap in optix by switching to cached ImageBuf#2155AlexeySmolenchuk wants to merge 3 commits into
AlexeySmolenchuk wants to merge 3 commits into
Conversation
… ImageBuf Signed-off-by: Alexey Smolenchuk <alexey.smolenchuk@gmail.com>
AlexeySmolenchuk
marked this pull request as ready for review
August 27, 2026 13:31
Collaborator
|
I think something is going wrong, see the logs in the failing optix version. |
Contributor
Author
|
Turns out the cached version is also buggy. |
AlexeySmolenchuk
marked this pull request as draft
August 28, 2026 11:30
Signed-off-by: Alexey Smolenchuk <alexey.smolenchuk@gmail.com>
Contributor
Author
|
AlexeySmolenchuk
marked this pull request as ready for review
August 28, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR workarounds this issue
I also increased maxAnisotropy to the maximum to prevent overblurring and match CPU results better.
Tests
Expect some Optix tests may fail.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.