Filesystem Browser fixes#271
Merged
tedwaine merged 3 commits intoJun 18, 2026
Merged
Conversation
kenmcgaugh
force-pushed
the
filesystem_browser_fixes
branch
from
55a8cbe to
2f7286f
Compare
Changed the Filesystem Browser hotkey from "B" to "Meta+B" as it was clashing with the the existing "B" hotkey to view the blue channel. When no playlist exists, a "File System Import" playlist was being created and viewed, but not inspected. Added a change to also make it the inspected playlist. Reworked the UI instantiation logic to leverage the built-in xstudio panel API. This fixed the broken hotkey, which required adding a button to the action bar as well. Removed the "Plugins|Browser Open" menu as the new action bar button does the same thing. Removed the "View|Panels" menu as it just wasn't working and it was redundant. Reworked the drag-and-drop to allow it to work from the pop-out window version of the browser the same way it works from the embedded panel version. Previously it just didn't work in the pop-out window. Modified the preview logic to prevent from being triggered excessively. Changing any of the filter settings causes a refresh of the current path. This provides both immediate results for any media directly within the current path, and also resets the deep-scan so it can be manually triggered again. Previously there was no easy way to force a refresh when changing the filter settings (that I could see). Fixed a couple of error messages. Fixed a focus issue when tripple-clicking in the path field to select the whole text. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk> Signed-off-by: Ken McGaugh <ken@wetafx.co.nz>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk> Signed-off-by: Ken McGaugh <ken@wetafx.co.nz>
…nt but with vastly different names:
mypath = "/path/to/media.mov"
m1 = myplaylist.add_media(mypath)
m2 = myplaylist.add_media(URI(mypath))
The m1 media item will have the name "/path/to/media.mov" whereas the m2 media item will have the name "media".
This discrepancy comes up with the new filesystem browser when adding media via drag-n-drop vs. double clicking.
The fix here is to make it so that the first method procuces the shorter name matching the second method.
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@wetafx.co.nz>
kenmcgaugh
force-pushed
the
filesystem_browser_fixes
branch
from
2f7286f to
906a1ec
Compare
tedwaine
merged commit 8e761c7
into
AcademySoftwareFoundation:develop
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few big issues and adds a couple of small improvements to the Filesystem Browser. Here is the complete rundown...
Added ".mxf" as a media file extension.
Changed the Filesystem Browser hotkey from "B" to "Meta+B" as it was clashing with the the existing "B" hotkey to view the blue channel.
When no playlist exists, a "File System Import" playlist was being created and viewed, but not inspected. Added a change to also make it the inspected playlist.
Reworked the UI instantiation logic to leverage the built-in xstudio panel API. This fixed the broken hotkey, which required adding a button to the action bar as well.
Removed the "Plugins|Browser Open" menu as the new action bar button does the same thing.
Removed the "View|Panels" menu as it just wasn't working and it was redundant.
Reworked the drag-and-drop to allow it to work from the pop-out window version of the browser the same way it works from the embedded panel version. Previously it just didn't work in the pop-out window.
Modified the preview logic to prevent from being triggered excessively.
Changing any of the filter settings causes a refresh of the current path. This provides both immediate results for any media directly within the current path, and also resets the deep-scan so it can be manually triggered again. Previously there was no easy way to force a refresh when changing the filter settings (that I could see).
Fixed a couple of error messages.
Fixed a focus issue when triple-clicking in the path field to select the whole text.