Fix ffprobe plugin returning empty result for webm/mkv#272
Merged
tedwaine merged 1 commit intoJun 18, 2026
Merged
Conversation
The leftover-options check came from fftools/ffprobe.c (~line 3890),
where it's a `while av_dict_iterate` loop that logs a warning for each
option the demuxer didn't consume. Reasonable in a CLI: tell the user
the `-foo` they typed didn't apply.
The port turned that warning into a throw, and kept a stale error
string ("Option scan_all_pmts not found") that doesn't describe what's
actually being detected.
It only stays quiet for mov/mp4 because xstudio seeds `export_all=1`
above, and the mov demuxer consumes it. Matroska/webm doesn't know
the option, leaves it in the dict, the throw fires, the catch resets
the result, and probe_file returns {} — so webm media shows no codec,
resolution, etc. in the media view.
This check is not needed.
Signed-off-by: Ben de Luca <bdeluca@gmail.com>
tedwaine
merged commit 0f60669
into
AcademySoftwareFoundation:develop
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leftover-options check after
avformat_find_stream_infothrows if any option is left in the dict. mov/mp4 stay quiet because the mov demuxer consumes theexport_all=1seed; matroska/webm doesn't know that option, leaves it behind, the throw fires, andprobe_filereturns{}— so webm media shows no codec, resolution, etc. in the media view. The stale error string ("Option scan_all_pmts not found") doesn't even describe what's actually being detected. Drop the check — fftools/ffprobe.c only used the equivalent loop to log a per-option CLI warning, not as a hard error.