Misc improvements#278
Open
kenmcgaugh wants to merge 4 commits into
Open
Conversation
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…python API was referencing it even though it wasn't exposed. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Under MacOS, these changes swap Ctrl/Control, Meta, and Alt for Cmd/Command, Ctrl/Control, Opt/Option in menus, tooltips, and the new hotkey manager. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Some are self-explanatory fixes for warnings or spurious debug messages, but for those that are not: src/ui/qml/session/src/session_model_methods_ui.cpp Modified SessionModel::handleOtherDropFuture() to use getNextName() for creating the playlist name. src/utility/src/chrono.cpp This doesn't appear to be used anywhere in xstudio, but under our ubunutu build environment it doesn't compile as-is. So this has been modified to use an older/more portable method. ui/qml/xstudio/application/XsSessionWindow.qml If xstudio is started in presentation mode, the Tab hotkey wouldn't work correctly. This fix forces it to change to "Review" mode in that situation. ui/qml/xstudio/application/auxillary/XsConformTool.qml When multiple media items are selected and Conform->Compare operation is called, the newly added media are not in a sensible order. This change makes it so that the newly added media items are always next to the item against which they are being compared. ui/qml/xstudio/application/panels/media/list_view/XsMediaList.qml Changed to prevent onContentYChanged triggering itself. Putting a debug output within this handler showed that it was being called twice before the beforeMoveContentY guard could break the recursion. ui/qml/xstudio/application/panels/media/functions/XsMediaListFunctions.qml When using Shift+Down to extend the selection downwards didn't work when only the first media item is selected. When deleting an item in the middle of the container, select the item *after* the deleted item rather than the one before it. This way doing a Copy, Delete, Paste sequence (or a not-yet-implemented Cut-Paste operation) returns the list to its original order. ui/qml/xstudio/application/panels/media/grid_view/XsMediaGrid.qml This copies over the feature from the XsMediaList.qml that keeps the scroll position when media items are deleted. ui/qml/xstudio/application/panels/playlists/XsPlaylists.qml Commented out a line that was causing a qml error. This doesn't appear to change any functionality, however I suspect the error was preventing some desired function from working (namely being able to Escape out of a pop-up window). Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes and improvements I've made along the way that should be mostly cosmetic or at least non-controversial. Please see the commit messages for more details.