Repository navigation
perf(renderd-host): sharpen a still screen at native size, and fix software colour maths - #172
Merged
Merged
Conversation
…ftware colour maths Move the encoder up to the display's native size once the screen has been still, then back to the link's size on motion. Decode the software path as BT.709 limited range instead of full-range BT.601, and pin the capture to sRGB/BT.709.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes aimed at text sharpness on slow links.
Sharpen on idle. After 500 ms of stillness the encoder moves up to the display's native size for one full-resolution keyframe and two refinement passes, then returns to the link's size when the screen moves again. Skipped if the keyframe would take over 1.2 s to drain.
Colour. The software renderer decoded BT.709 limited-range as full-range BT.601 (greys for blacks, dim whites). Fixed. Capture is pinned to sRGB/BT.709 and the tags are logged; on this Mac the tags were already BT.709, so that part is defensive. Added
renderd-sc-sysexamplecolour_probe.Verified: workspace clippy and fmt clean, host/viewer/sc-sys tests pass, capture tested on macOS. Not yet exercised end to end against a Windows viewer.