Strip unstable rustfmt, normalize to stable 1.94.1, fix burn refs#133
Merged
Conversation
Removed 14 unstable options (brace_style, indent_style, format_macro_bodies, skip_macro_invocations, etc.) that were silently ignored by stable rustfmt. Updated edition from 2018 to 2021. Stable config only. Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
One-time reformatting of 303 source files to match the stable-only rustfmt.toml. Primary changes: K&R brace style (was Allman), macro body formatting, import layout, line wrapping at 120 cols. No functional changes — whitespace only. Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
- Replace tracel-ai/burn git refs with AdaWorldAPI/burn@9b2b671 - Update submodule URL to AdaWorldAPI/burn - Exclude crates/burn from workspace (rand 0.10 vs 0.9 conflict) Burn is built standalone via `cargo check -p burn --manifest-path crates/burn/Cargo.toml` Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 13, 2026
PR #133 (commits 7ca1cf3 + ed59b3b) stripped all 13 nightly-only directives from `rustfmt.toml` and normalized the codebase to stable rustfmt 1.94.1. The CI fmt job, however, was never updated to leverage this — it still used: uses: dtolnay/rust-toolchain@nightly continue-on-error: true …which left fmt failures showing as "passing" on PR checks (an atom-bomb red flag for code-style invariants). The original `continue-on-error: true` rationale ("5,679 drift sites with nightly rustfmt") was dependent on the nightly-only directives that PR #133 already removed. The band-aid was stale. This commit completes what PR #133 implied: - Switch fmt job from `dtolnay/rust-toolchain@nightly` to `dtolnay/rust-toolchain@1.95.0` (the rust-toolchain.toml pin). - Remove `continue-on-error: true` — fmt failures now block merge, as they should. - Rename the job from `format/nightly` → `format/stable` to reflect the actual toolchain. - Replace the stale 24-line comment block with a 12-line explanation citing PR #133 as the source of stable-clean state. Plus the 3 drift sites between stable 1.94.1 and stable 1.95.0 (import ordering changes in `src/hpc/clam.rs`, `src/hpc/mod.rs`, `src/hpc/udf_kernels.rs`) — `cargo fmt --all` on 1.95.0 normalizes them. Bundled with the 1.95 bump since this PR is the trigger. Verified: `cargo fmt --all --check` clean on 1.95.0 post-commit. Companion to PR #133 / "where did that PR go" — completes the missed step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1.
rustfmt.toml— stable options onlyRemoved 14 unstable options that were silently ignored by stable rustfmt. Kept stable-only config:
edition = "2021",max_width = 120,fn_params_layout = "Compressed", etc.cargo fmt --all --checknow passes clean on stable 1.94.12. Codebase reformatted (303 files, whitespace only)
One-time normalization to stable rustfmt. Primary changes:
brace_style = "AlwaysNextLine")format_macro_bodies = false)3. Burn crate references fixed
tracel-ai/burn→AdaWorldAPI/burn@9b2b671incrates/burn/Cargo.toml.gitmodulescrates/burnexcluded from workspace resolver (rand 0.10vs workspacerand 0.9conflict)Verification
cargo fmt --all --check— 0 diffs (was 4473)cargo clippy --features native -- -D warnings— cleancargo test --lib -p ndarray— 1819 passed, 0 failed, 36 ignoredcargo check— workspace resolves cleanly