fix(doctests): fix 3 doctest failures breaking CI#139
Closed
AdaWorldAPI wants to merge 2 commits into
Closed
Conversation
1. crystal_encoder::distill — remove unused import `Role` 2. nibble::nibble_propagate_bfs — remove unused import `nibble_unpack` 3. udf_kernels::udf_sigma_classify — swap band/threshold args in doctest assertions (distance=100 with threshold=1000 → Foveal, not distance=1000 with threshold=100 → Reject) All 3 fail under CI's RUSTFLAGS="-D warnings". Now: 335 doctests pass, 0 fail, 7 ignored. Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
dtolnay/rust-toolchain installs the target for the matrix toolchain (stable), but rust-toolchain.toml overrides cargo to use 1.94.1 which doesn't have thumbv6m-none-eabi installed. Add explicit rustup target add to ensure the pinned toolchain has the cross-compile target. Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
AdaWorldAPI
added a commit
that referenced
this pull request
May 13, 2026
…d-nostd Doctest fixes (from #139) + unblock i686 cross-tests + thumbv6m nostd build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has 4 failures across jobs:
tests/stable— 3 doctest failures (underRUSTFLAGS="-D warnings")crystal_encoder::distillRolenibble::nibble_propagate_bfsnibble_unpackudf_kernels::udf_sigma_classify"noise"not"exact"band/thresholdargs —(100, 1000)not(1000, 100)nostd/thumbv6m-none-eabi— missing target for pinned toolchaindtolnay/rust-toolchain@stableinstallsthumbv6m-none-eabifor whicheverstableresolves to, butrust-toolchain.tomloverrides cargo to1.94.1which doesn't have the target →error[E0463]: can't find crate for core.Fix: add
rustup target add ${{ matrix.target }}so the pinned toolchain gets it too.Verification
RUSTFLAGS="-D warnings" cargo test --doc -p ndarray— 335 passed, 0 failed, 7 ignoredcargo test --lib -p ndarray— 1776 passed, 0 failed, 36 ignored