Migrate benches to criterion (stable Rust) + clear remaining clippy errors

Cargo.toml

@@ -79,6 +79,56 @@ quickcheck = { workspace = true }
 approx = { workspace = true, default-features = true }
 itertools = { workspace = true }
 ndarray-gen = { workspace = true }
+criterion = { version = "0.5", features = ["html_reports"] }
+
+[[bench]]
+name = "append"
+harness = false
+
+[[bench]]
+name = "bench1"
+harness = false
+
+[[bench]]
+name = "chunks"
+harness = false
+
+[[bench]]
+name = "construct"
+harness = false
+
+[[bench]]
+name = "gemv_gemm"
+harness = false
+
+[[bench]]
+name = "higher-order"
+harness = false
+
+[[bench]]
+name = "iter"
+harness = false
+
+[[bench]]
+name = "numeric"
+harness = false
+
+[[bench]]
+name = "par_rayon"
+harness = false
+required-features = ["rayon"]
+
+[[bench]]
+name = "reserve"
+harness = false
+
+[[bench]]
+name = "to_shape"
+harness = false
+
+[[bench]]
+name = "zip"
+harness = false
 
 [features]
 default = ["std", "hpc-extras"]

benches/append.rs

@@ -1,29 +1,30 @@
-#![feature(test)]
-
-extern crate test;
-use test::Bencher;
-
+use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use ndarray::prelude::*;
 
-#[bench]
-fn select_axis0(bench: &mut Bencher) {
+fn select_axis0(c: &mut Criterion) {
     let a = Array::<f32, _>::zeros((256, 256));
     let selectable = vec![0, 1, 2, 0, 1, 3, 0, 4, 16, 32, 128, 147, 149, 220, 221, 255, 221, 0, 1];
-    bench.iter(|| a.select(Axis(0), &selectable));
+    c.bench_function("select_axis0", |b| {
+        b.iter(|| black_box(&a).select(Axis(0), black_box(&selectable)))
+    });
 }
 
-#[bench]
-fn select_axis1(bench: &mut Bencher) {
+fn select_axis1(c: &mut Criterion) {
     let a = Array::<f32, _>::zeros((256, 256));
     let selectable = vec![0, 1, 2, 0, 1, 3, 0, 4, 16, 32, 128, 147, 149, 220, 221, 255, 221, 0, 1];
-    bench.iter(|| a.select(Axis(1), &selectable));
+    c.bench_function("select_axis1", |b| {
+        b.iter(|| black_box(&a).select(Axis(1), black_box(&selectable)))
+    });
 }
 
-#[bench]
-fn select_1d(bench: &mut Bencher) {
+fn select_1d(c: &mut Criterion) {
     let a = Array::<f32, _>::zeros(1024);
     let mut selectable = (0..a.len()).step_by(17).collect::<Vec<_>>();
     selectable.extend(selectable.clone().iter().rev());
-
-    bench.iter(|| a.select(Axis(0), &selectable));
+    c.bench_function("select_1d", |b| {
+        b.iter(|| black_box(&a).select(Axis(0), black_box(&selectable)))
+    });
 }
+
+criterion_group!(benches, select_axis0, select_axis1, select_1d);
+criterion_main!(benches);