Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(simd): re-export f32_to_bf16_batch_rne / f32_to_bf16_scalar_rne Makes the pure AVX-512-F RNE routines from commit c489d31 reachable as
ndarray::simd::f32_to_bf16_batch_rneandndarray::simd::f32_to_bf16_scalar_rnefor consumer code in lance-graph. Without this re-export, callers would have to reach into the privatesimd_avx512module path, which is notpub modinlib.rs. Doc comment on the re-export explicitly pins the workspace-wide "never scalar ever" rule for F32→BF16: consumer hot loops usef32_to_bf16_batch_rneexclusively (500-20,000× faster than scalar via AMX/AVX-512-BF16 tiles), andf32_to_bf16_scalar_rneis exposed only as a unit-test reference implementation. Cross-references the Certification Process section inlance-graph/CLAUDE.md. Companion commit in lance-graph updatesseven_lane_encoder.rsLane 6 to call the batch primitive instead of its previous element-wise truncation loop. https://claude.ai/code/session_019RzHP8tpJu55ESTxhfUy1A #88New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simd): re-export f32_to_bf16_batch_rne / f32_to_bf16_scalar_rne Makes the pure AVX-512-F RNE routines from commit c489d31 reachable as
ndarray::simd::f32_to_bf16_batch_rneandndarray::simd::f32_to_bf16_scalar_rnefor consumer code in lance-graph. Without this re-export, callers would have to reach into the privatesimd_avx512module path, which is notpub modinlib.rs. Doc comment on the re-export explicitly pins the workspace-wide "never scalar ever" rule for F32→BF16: consumer hot loops usef32_to_bf16_batch_rneexclusively (500-20,000× faster than scalar via AMX/AVX-512-BF16 tiles), andf32_to_bf16_scalar_rneis exposed only as a unit-test reference implementation. Cross-references the Certification Process section inlance-graph/CLAUDE.md. Companion commit in lance-graph updatesseven_lane_encoder.rsLane 6 to call the batch primitive instead of its previous element-wise truncation loop. https://claude.ai/code/session_019RzHP8tpJu55ESTxhfUy1A #88Changes from all commits
2a7f89ed8b7b8e17bfde3c489d317caefe9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.