image block with custom variant - #729
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-12T11:40:52.907Z |
davids-ensemble
left a comment
There was a problem hiding this comment.
A few changes I would want to see implemented:
- let's call it "Standalone Image" instead of just "Image"
- let's require a caption:
- second row in the table or similar
- hide the caption by default (display: none)
- generate and set an
idon the caption - add
aria-labelledbyreferencing that id value to the image
Main reason for this is to align it with DevDocs' Image Block
In the future, if anyone will require it, we can offer an option to show the caption as well.
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-14T06:24:08.977Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-14T06:50:32.075Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-14T10:39:03.646Z |
davids-ensemble
left a comment
There was a problem hiding this comment.
This looks good to me but I want @melissag-ensemble to also take a quick look.
There was a problem hiding this comment.
We should confirm design sign-off before implementation on this. Let's discuss in slack
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T06:15:56.249Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:12:09.592Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:13:47.647Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:24:17.129Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:27:18.889Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:42:48.876Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:49:30.791Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T07:56:58.774Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-08-17T08:00:25.884Z |
melissag-ensemble
left a comment
There was a problem hiding this comment.
Holding review until scope is confirmed — this PR adds a medium variant and a caption beyond the image variant Madhur approved. Can you settle the design for those with Madhur first, then re-request review? (Context in Slack.)
Description
Image block with custom variant(medium and background color)
Jira
https://jira.corp.adobe.com/browse/DEVSITE-2519
Test URL
https://devsite-2519--adp-devsite-stage--adobedocs.aem.page/test/petheanraj/image