Add novatel quality entry to gga parsing - #155
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 80.33% 80.01% -0.33%
==========================================
Files 39 39
Lines 1500 1506 +6
==========================================
Hits 1205 1205
- Misses 295 301 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Some receivers (e.g. Novatel) report fix quality 9 for SBAS-augmented fixes. Previously the parser rejected this value. - Add FixType::Sbas variant with is_valid() returning true - Extend GGA parser to accept '9' in fix quality field - Add From<char>/to_nmea_char roundtrip for '9' Addresses issues AeroRust#154 and AeroRust#155. Co-Authored-By: Andreas Corneliussen <andreasbc@users.noreply.github.com>
elpiel
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
With this small doc. request fixed we can merge this.
| Estimated, | ||
| Manual, | ||
| Simulation, | ||
| WAAS, |
There was a problem hiding this comment.
- Could you please document in which manufacturers and devices this is know to exist.
if there's any information about datasheet and protocol or similar to document it's use, this would be perfect.
|
This is a proprietary extension to the GGA fix quality indicator, so I don't think we should accept this. Instead we should have a catch all for values outside the standard, so that we don't crash and just serve the value as |
Add Fixtype::WAAS to fix-quality entry of GGA sentence to support novatel GPS's
Fixes #154