Repository navigation
fix(ship): preserve quoted slash arguments and reject invalid flags - #293
Merged
Merged
Conversation
Owner
Author
|
Final gate review for exact head
These are failures in shared release evidence and repository access, not passing required statuses. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #276.
Change
--flag=valuewithout a shell./shiptitle, body, base, approval, yes, JSON preview, and help options. Reject missing values, unterminated quotes, unsupported or duplicate flags, and positional input with usage before any publication step./help shipand generated command documentation.Evidence
shipSlashwrapper keeps a Unicode title with quotes and literal$(...)/backticks, and a multiline body, as single argv values matching the CLI parse.gh pr createargv matches the fake GitHub call after approval.git diff --check.