Repository navigation
feat: preview and edit shell results before model sharing (#281) - #308
Conversation
|
Exact-head review for
The remaining red/queued checks have separate causes: GitHub artifact storage quota rejects evidence uploads; the Linux job cannot fetch the pinned private ATSv2 repository ( Reviewed flow: preview and edits are local; send uses the exact staged attachment; a later command cannot replace it; cancelled and empty selections yield no chat turn. Shared text is excluded from console history and continuation/auth-repair drafts. Support bundles use metadata-only redacted events and exclude prompts and tool output. |
|
Acceptance review for #281 at exact head
These checks compiled and ran without changing this branch. PR #309 contains an independently tested implementation addressing these boundaries, plus TTY/pipe history, failure-recovery, immutable queued-send and local-backend coverage. There is overlapping work; neither implementation should be counted as closure evidence until the chosen combined change passes the acceptance tests on its landed revision. No claim of production exposure or live-service qualification is made. |
Closes #281.
What changed
/shell-resultstages and prints the exact sanitized prompt attachment. Users can inspect numbered lines, drop or replace a line, mask a literal, apply the existing redaction aid, send, or cancel./shell-result sendis the explicit one-step form for pipe/JSON sessions. Preview, edit, cancel, and empty selections do not call a model. Shared content retains untrusted-data framing and is excluded from console history, task continuation, and auth-repair drafts.Evidence
npm run docs:checkpassed (build/typecheck and six generated documentation outputs).node --test dist/test/console_input.test.js dist/test/console_shell.test.js dist/test/bounded_output.test.js dist/test/shell_output_capture.test.js dist/test/shell_session.test.js— 27 passed, 0 failed; 18 platform-specific tests skipped on Windows.Linux runner checks are expected to exercise persistent-shell cases skipped on Windows.