Skip to content

Inspect, edit and discard bounded typed pending console entries - #311

Closed
AetherAI3 wants to merge 1 commit into
fix/281-shell-result-previewfrom
fix/284-manage-pending-queue
Closed

AetherAI3 wants to merge 1 commit into
fix/281-shell-result-previewfrom
fix/284-manage-pending-queue

Conversation

@AetherAI3

Copy link
Copy Markdown
Owner

Summary

Implements issue #284 on top of the defensive shell-attachment follow-up in #309. This PR is intentionally stacked on fix/281-shell-result-preview and should land only after #309.

  • Stable local IDs and explicit pending chat/user-shell/shell-share types
  • Local responsive list/edit/remove/clear during an active stream; active input stays immutable
  • Strict FIFO, count/UTF-8 bounds (32 pending entries/64KiB), and rejected edits preserve type and position
  • Edited shell-share keeps capture identity but revokes old Send approval; explicit reapproval is required and FIFO pauses
  • Failure/cancel/checkout change/shell loss/auth-new/exit report discarded IDs and cannot silently replay them
  • Pipe mode remains documented sequential behavior; local management never becomes a prompt/history
  • Terminal handoff cannot change a pending queue checkout; existing model-switch controls and saved draft remain usable

Verification

Linux Node24.19.0; synthetic fixtures and mocked models, no paid inference. Final full npm test:3,383 pass,11 platform/environment skips,0 failures (3,394 total). Focused console/attachment/queue/model-continuation suite:57 pass. Explicit model/process spies prove removed, cleared and cancelled pending inputs do not execute. Independent reviewer verified malformed-control, terminal, exit and model-switch regressions.

Build, typecheck, lint, docs:check, verify:production, npm pack --dry-run and git diff --check passed. Smoke still fails public DNS resolution in this executor; release:truth still fails the independently reproduced #303 frozen-packet baseline (11/12 checks). No CI gate/security/branch-protection setting was weakened. Actual required Windows/Linux/CodeQL/packaging CI must pass before merge and issue closure.

See docs/issue-284-validation.md for acceptance details. No auto-closing keyword: closure waits for landed evidence after #281 follow-up.

@AetherAI3

Copy link
Copy Markdown
Owner Author

Heads-up: #284 landed via #315 (squash 52a890c), which adds src/commands/console_queue.ts and rewires the queue in chat.ts. This draft now conflicts with main. If any guarantee here isn't covered by #315 (for example, checkout-change discard, or revoking an edited shell-share send approval), please rebase it onto main as a follow-up. Otherwise this PR can be closed as superseded.

Copy link
Copy Markdown
Owner Author

Superseded by the already-merged queue implementation in #315. The remaining #281/#284 privacy, exact reviewed-snapshot binding, queue-control parsing and shell-generation fixes are consolidated in #309 at 0a079c4ba466ce1b4f121a9d8d4fc7a5d84cb95f, preserving #315's hold/resume UX and the newer PowerShell/steering changes. Closing this duplicate proposal without merging it; this closure does not assert that #309 or all issue acceptance/CI gates have passed. The branch and existing test evidence remain available.

@AetherAI3 AetherAI3 closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant