Repository navigation
Start RC viewing without operator device enrollment - #313
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
aether rc startrequiredaether device enroll, but that enrollment is operator-only. Ordinary accounts could have RC viewing enabled and still be unable to start an observer session.Change
POST /remote/device-identityendpoint for the RC-only device label.The Cloud endpoint is in AETHER-CLOUD #1944, which should merge before this PR is released. The RC label is not a control credential; existing control paths remain separately authenticated.
Verification
npm run buildpassed.node --test --test-isolation=none dist/test/rc_device_identity.test.js dist/test/rc_command.test.js dist/test/rc_lifecycle.test.js dist/test/rc_viewer_host.test.js: 114 passed, 0 failed, 0 skipped./device/v1/calls. Other tests cover stable local identity, corrupt-state refusal, and a 403 that stops before session registration.git diff --cached --checkpassed.Live deployment qualification remains separate from these source tests.
Closes #300