Allow any expression as the value of CAST - #304
Merged
Conversation
CAST read its value with the primary expression parser, so an operator stopped it: CAST(a + 1 AS String) and CAST(a + 1, 'String') both failed at the plus sign. Parse the value at the lowest precedence instead, which also accepts a leading minus as in CAST(-1 AS Int8).
The end position of the column was read from the expression before the error was checked, so any parse failure in DEFAULT, MATERIALIZED or ALIAS dereferenced a nil expression.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAST read its value with the primary expression parser, so an operator
stopped it: CAST(a + 1 AS String) and CAST(a + 1, 'String') both failed
at the plus sign. Parse the value at the lowest precedence instead,
which also accepts a leading minus as in CAST(-1 AS Int8).
There is a second (unrelated) commit to fix a crash that I discovered at the same time while debugging this issue.