Repository navigation
Make built-in provider lists extensible - #1795
Merged
Merged
Conversation
ZeroPoint95
marked this pull request as ready for review
October 8, 2026 14:05
ZeroPoint95
marked this pull request as draft
October 8, 2026 14:44
ZeroPoint95
marked this pull request as ready for review
October 8, 2026 14:52
4 tasks done
fenilmodi00
added a commit
to fenilmodi00/CodeAF-aiand
that referenced
this pull request
Oct 8, 2026
… row, rework the entry dev stopped counting providers in prose (Agent-Field#1795), which is what conflicted. commands.md and services.md take the dev side; modelsource_test.go keeps our want list with aiand at index 5 and takes dev's at-least check. The change entry follows the review: Connections category wording, the count bullet dropped, and the body cut to a third led by what one aiand key buys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a built-in provider could hide OpenRouter at 40×10, break tests that pinned the catalog size or put Custom API last, and leave manual pages claiming a fixed provider count. The chooser now omits its key-hint footer before clipping a provider row. Catalog tests allow appended rows, pagination checks are count-agnostic, and the manual and guide describe every built-in provider without enumerating the catalog.
A manual guard rejects numeric and spelled-out catalog counts across both corpora and the guide. Counts of connection choices, such as “this provider offers two options: browser sign-in or an API key,” remain valid. Regression cases cover those descriptions alongside the existing positive catalog cases.
No provider is added by this PR; #1737 supplies ai& separately. The change entry is
docs/changes/unreleased/1795-provider-list-extensible.md.Validation:
Vendored()produced ten chooser entries. At 40×10 all ten rows were visible, including OpenRouter, and the footer was absent for both first and last selections. Full scratch-catalog tests passed: tui3 65.168s; manual 2.136s. The temporary source and scratch test were removed.5d7979adc. The eleven tui3 race failures reproduced on unchanged dev15edceb1d; manual and modelsource passed under race. The latest commit changes only the manual guard tests.go test -race -count=1 ./internal/manualpassed in 18.926s,go vet ./internal/manualpassed, andmake test-lawspassed. All prior positive guard cases still pass, and the connection-choice examples are accepted.make buildproducedbin/codeaf; its version smoke check reports clean commita93263a75, darwin/arm64, Go 1.27.0.make pr-readywas omitted as requested. The PR is returned to draft pending independent review of the updated head.