The README tells contributors which pull requests get the automated Claude review and how a fork PR gets one - #83
Merged
Conversation
…laude review and how a fork PR gets one Three contributor PRs in a row (#77, #79, #81) came from a fork and showed the automated review failing, and nothing in the repo said that the review only runs for branches pushed here, or that a maintainer can ask for one with @claude in a comment. A paragraph under Building, next to the note on how releases are cut, now says both. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in the repository said which pull requests get the automated Claude review or why a fork PR's review fails; the README's Building section now says both, in one paragraph next to the note on how releases are cut.
Contents: 1. The problem · 2. What changed · 3. How it looks · 4. How it works · 5. Risk · 6. Technical overview · 7. Notes
1. The problem
Three contributor PRs in a row (#77, #79, #81) arrived from a fork and each showed the
claude-reviewcheck failing, before anyone had read the diff. The cause is GitHub's, not the contributor's: apull_requestrun of fork code gets no secrets and no OIDC token, so the reviewer cannot authenticate. #82 makes that check skip instead of fail, but the README still told a contributor nothing about what review to expect, or how to get one.2. What changed
@claudein a PR comment.3. How it looks
A README paragraph has no screen to shoot; this is the paragraph as it renders, under Building, after the note on releases:
4. How it works
flowchart LR PR[pull request opened] --> Q{head branch lives in this repo?} Q -- yes --> AUTO["claude-review runs\ninline comments on the PR"] Q -- no, a fork --> SKIP["claude-review skipped (#82)"] SKIP --> M[maintainer reads the diff] M -- "@claude in a comment" --> BOT["Claude Code workflow\nruns with this repo's credentials"] M -- by hand --> DONE[review] BOT --> DONE AUTO --> DONE5. Risk
Verdict: 🟢 Low risk — prose only; nothing that runs is touched.
Rollback:
git revertof the merge removes the paragraph; nothing else to undo.6. Technical overview
.github/workflows/: the review workflow runs onpull_requestand needs the repository's OIDC token and OAuth secret, which GitHub grants to same-repo branches only; the@claudeworkflow runs onissue_commentin the base repository's context, so a maintainer's comment reaches the reviewer with credentials even on a fork PR.README.md— one paragraph added under Building.make cinot run: the diff is Markdown only.7. Notes
mainafter README: custom harness guide and supported CLIs with install links #81; independent of The Claude review check skips pull requests from forks instead of failing on them #82, and its ownclaude-reviewcheck is the end-to-end run that The Claude review check skips pull requests from forks instead of failing on them #82's could not be (a PR that edits the review workflow is skipped by the action itself).🤖 Generated with Claude Code