ci: run the CLI packaging gate when its own inputs change - #610
Conversation
#608 added scripts/cli-package-gate.mjs (run by packages/sdk/tests/cli-package-gate.test.ts) to catch a runtime dependency missing from the published CLI. The workflows that run that test only trigger on pull requests touching packages/sdk/** (and their own paths), so a PR that changes only the gate script or packages/relayflows/** (the `relayflows` wrapper package, whose dependency on @relayflows/sdk the gate installs) skipped it. Add both paths to the pull_request filters of cloud-runtime-artifact.yml and to both filters of surface-package.yml. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTwo GitHub Actions workflows now include ChangesWorkflow path triggers
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~7 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The relevant pull requests will run the CLI package gate when its script or the Relayflows package changes. No actionable merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the paths at dawn Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2f38aba5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…lter Review on #610 (Devin, Codex): the gate also runs scripts/pack-release.mjs, packs packages/surface/**, and checks examples/dependency-upgrade-bot/dependency-upgrade-bot.flow.ts, so a PR touching only one of those still skipped it. And the gate only runs in cloud-runtime-artifact.yml's full vitest run; surface-package.yml runs tests/authored-flow.test.ts, so adding the paths there gated nothing. Put all gate inputs in cloud-runtime-artifact.yml's pull_request filter, with a comment saying why, and drop the surface-package.yml change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 participant
Follow-up to #608, flagged by its finishing agent (whose token could not push workflow files).
scripts/cli-package-gate.mjsruns inside the SDK test suite (packages/sdk/tests/cli-package-gate.test.ts), which onlycloud-runtime-artifact.ymlruns on pull requests (its fullvitest run). That workflow's PR filter coveredpackages/sdk/**but none of the gate's other inputs, so a PR touching only them skipped the gate.Adds to
cloud-runtime-artifact.yml'spull_requestpaths, with a comment:scripts/cli-package-gate.mjs,scripts/pack-release.mjs(the packer it runs),packages/relayflows/**andpackages/surface/**(packed and installed with the SDK), andexamples/dependency-upgrade-bot/dependency-upgrade-bot.flow.ts(the fixture it checks). Itspushto main is deliberately unfiltered and unchanged. YAML validated; no job changes.🤖 Generated with Claude Code
Note
Low Risk
CI path-filter-only change; no runtime, packaging script, or job logic modifications.
Overview
Expands
pull_requestpath filters oncloud-runtime-artifact.ymlso the Linux artifact job (and its full SDK vitest run, includingcli-package-gate.test.ts) runs when CLI packaging gate inputs change—not only whenpackages/sdk/**changes.New triggers cover
scripts/cli-package-gate.mjs,scripts/pack-release.mjs,packages/relayflows/**,packages/surface/**, andexamples/dependency-upgrade-bot/dependency-upgrade-bot.flow.ts, with an inline comment documenting why those paths are tied to the gate. No job or step changes; push-to-mainbehavior stays unfiltered as before.Reviewed by Cursor Bugbot for commit 5335ab2. Bugbot is set up for automated code reviews on this repo. Configure here.