-
Notifications
You must be signed in to change notification settings - Fork 68
fix(broker): cover overloaded mcp-args registration #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khaliqgant
merged 2 commits into
fix/relay-1715-spawn-overload
from
fix/relay-1730-overload-finish
Sep 10, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
74 changes: 74 additions & 0 deletions
74
.agentworkforce/trajectories/completed/2026-09/traj_shd42liwvlpd.trace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "id": "2f7178f0-a2ba-4c9a-ad4a-7102fb547dbe", | ||
| "timestamp": "2026-09-10T18:07:12.764Z", | ||
| "trajectory": "traj_shd42liwvlpd", | ||
| "files": [ | ||
| { | ||
| "path": "CHANGELOG.md", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 9, | ||
| "end_line": 15, | ||
| "revision": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/cli_mcp_args.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 4, | ||
| "end_line": 11, | ||
| "revision": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022" | ||
| }, | ||
| { | ||
| "start_line": 172, | ||
| "end_line": 186, | ||
| "revision": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022" | ||
| }, | ||
| { | ||
| "start_line": 632, | ||
| "end_line": 638, | ||
| "revision": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022" | ||
| }, | ||
| { | ||
| "start_line": 670, | ||
| "end_line": 682, | ||
| "revision": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "tests/relayflows/cases/1715-spawn-overload/run.mjs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 140, | ||
| "end_line": 159, | ||
| "revision": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
40 changes: 40 additions & 0 deletions
40
.agentworkforce/trajectories/completed/2026-09/traj_shd42liwvlpd/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Trajectory: Finish Relay PR #1730 overload retries and mcp-args proof | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Task:** relay-1730-1715 | ||
| > **Confidence:** 90% | ||
| > **Started:** September 10, 2026 at 08:01 PM | ||
| > **Completed:** September 10, 2026 at 08:07 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Extended the broker-owned bounded Relaycast registration retry path to cli mcp-args --register, corrected the base proof marker contract, updated the changelog, and validated full broker tests plus exact base-red/head-green proof at bde1d4257d7a95484f4e3bcb86f0e3eb95124022. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Extended the broker-owned bounded registration retry helper into mcp-args --register | ||
| - **Chose:** Extended the broker-owned bounded registration retry helper into mcp-args --register | ||
| - **Reasoning:** The fresh Cloud proof showed the outer RelayFlow executor retried three times while each inner mcp-args registration reported attempts:1; the existing helper already owns typed 503 classification, bounded backoff, diagnostics, and takeover-safe registration. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Extended the broker-owned bounded registration retry helper into mcp-args --register: Extended the broker-owned bounded registration retry helper into mcp-args --register | ||
| - Broker spawn is green at head and red at base; Cloud mcp-args was a separate uncovered call site and now shares the same bounded retry path. Full broker tests pass. | ||
|
|
||
| --- | ||
|
|
||
| ## Artifacts | ||
|
|
||
| **Commits:** bde1d4257 | ||
| **Files changed:** 3 |
76 changes: 76 additions & 0 deletions
76
.agentworkforce/trajectories/completed/2026-09/traj_shd42liwvlpd/trajectory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| { | ||
| "id": "traj_shd42liwvlpd", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Finish Relay PR #1730 overload retries and mcp-args proof", | ||
| "source": { | ||
| "system": "plain", | ||
| "id": "relay-1730-1715" | ||
| } | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-09-10T18:01:46.070Z", | ||
| "completedAt": "2026-09-10T18:07:12.675Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-09-10T18:05:54.505Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_j655wk1uhsl5", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-09-10T18:05:54.505Z", | ||
| "endedAt": "2026-09-10T18:07:12.675Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1789063554506, | ||
| "type": "decision", | ||
| "content": "Extended the broker-owned bounded registration retry helper into mcp-args --register: Extended the broker-owned bounded registration retry helper into mcp-args --register", | ||
| "raw": { | ||
| "question": "Extended the broker-owned bounded registration retry helper into mcp-args --register", | ||
| "chosen": "Extended the broker-owned bounded registration retry helper into mcp-args --register", | ||
| "alternatives": [], | ||
| "reasoning": "The fresh Cloud proof showed the outer RelayFlow executor retried three times while each inner mcp-args registration reported attempts:1; the existing helper already owns typed 503 classification, bounded backoff, diagnostics, and takeover-safe registration." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1789063556526, | ||
| "type": "reflection", | ||
| "content": "Broker spawn is green at head and red at base; Cloud mcp-args was a separate uncovered call site and now shares the same bounded retry path. Full broker tests pass.", | ||
| "raw": { | ||
| "confidence": 0.88 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "confidence:0.88" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Extended the broker-owned bounded Relaycast registration retry path to cli mcp-args --register, corrected the base proof marker contract, updated the changelog, and validated full broker tests plus exact base-red/head-green proof at bde1d4257d7a95484f4e3bcb86f0e3eb95124022.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.9 | ||
| }, | ||
| "commits": [ | ||
| "bde1d4257" | ||
| ], | ||
| "filesChanged": [ | ||
| "CHANGELOG.md", | ||
| "crates/broker/src/cli_mcp_args.rs", | ||
| "tests/relayflows/cases/1715-spawn-overload/run.mjs" | ||
| ], | ||
| "projectId": "AgentWorkforce/relay", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "be109f9f94e641d35a842024418440b8b0a7ae3d", | ||
| "endRef": "bde1d4257d7a95484f4e3bcb86f0e3eb95124022", | ||
| "traceId": "2f7178f0-a2ba-4c9a-ad4a-7102fb547dbe" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routing
mcp-args --registerthrough this helper changes a persistent 503 from one POST withattempts: 1to three POSTs withattempts: 3, buttests/relayflows/cases/1673-relaycast-registration-diagnostics/run.mjslines 147-153 still accepts the head only whenrequestCount === 1and stderr containsattempts: 1. Consequently that compiled exact-head RelayFlow proof throws an unexpected-observation error at this head, and the new 1715 proof exercises only/api/spawn, not the Cloudmcp-args --registercall site; update or replace the exact base/head proof alongside this behavior change.Useful? React with 👍 / 👎.