-
Notifications
You must be signed in to change notification settings - Fork 1
feat(cli): use Agent Relay SDK for zero-friction setup #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
91497a2
feat(cli): use Agent Relay SDK for self-serve setup
khaliqgant 87a3e90
fix(cli): harden self-serve quickstart
khaliqgant 8ec0158
fix(cli): preserve canonical Cloud auth ownership
khaliqgant e482404
fix(cli): validate SDK login options
khaliqgant 2761e79
fix(cli): preserve single-dash setup credentials
khaliqgant 6479775
fix(cli): announce setup before SDK login
khaliqgant 2bfa1a2
fix(cli): authenticate when token flags are empty
khaliqgant ef72f45
fix(cli): identify Relayfile Cloud sign-in
khaliqgant cccaa2e
fix(cli): preserve parsed setup precedence
khaliqgant 541184a
fix(cli): mirror native setup value parsing
khaliqgant a559829
fix(cli): cancel timed out onboarding auth
khaliqgant e0b5ed3
fix(cli): match native help and version parsing
khaliqgant 809e137
fix(cli): abort device response reads
khaliqgant f088925
fix(cli): harden browser login completion
khaliqgant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| { | ||
| "id": "traj_2ng1fbz1wsxb", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Address final Relayfile self-serve onboarding review feedback and merge", | ||
| "source": { | ||
| "system": "plain", | ||
| "id": "PR-438" | ||
| } | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-08-23T14:42:40.801Z", | ||
| "completedAt": "2026-08-23T14:45:33.103Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-08-23T14:42:40.884Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_2fufyvo2tx68", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-08-23T14:42:40.884Z", | ||
| "endedAt": "2026-08-23T14:45:33.103Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1787496160884, | ||
| "type": "decision", | ||
| "content": "Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors: Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors", | ||
| "raw": { | ||
| "question": "Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors", | ||
| "chosen": "Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors", | ||
| "alternatives": [], | ||
| "reasoning": "The wrapper deadline alone could not extend the SDK's fixed five-minute callback timer, and Node child-process spawn failures bypass try/catch unless an error listener is attached." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1787496333041, | ||
| "type": "reflection", | ||
| "content": "Final review findings are addressed with one behavioral regression test; CLI tests, contract checks, Go tests, Go vet, syntax checks, and affected TypeScript package typechecks pass.", | ||
| "raw": { | ||
| "confidence": 0.95 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "confidence:0.95" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Propagated the configured login timeout through Relayfile's Cloud SDK boundary, handled asynchronous browser launcher failures, and added behavioral coverage for both.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.95 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/private/tmp/relayfile-438-fix.79dx8Z", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "809e137cb65e6479618549eea88e5d67a96aff0e", | ||
| "endRef": "809e137cb65e6479618549eea88e5d67a96aff0e" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Trajectory: Address final Relayfile self-serve onboarding review feedback and merge | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Task:** PR-438 | ||
| > **Confidence:** 95% | ||
| > **Started:** August 23, 2026 at 04:42 PM | ||
| > **Completed:** August 23, 2026 at 04:45 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Propagated the configured login timeout through Relayfile's Cloud SDK boundary, handled asynchronous browser launcher failures, and added behavioral coverage for both. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors | ||
| - **Chose:** Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors | ||
| - **Reasoning:** The wrapper deadline alone could not extend the SDK's fixed five-minute callback timer, and Node child-process spawn failures bypass try/catch unless an error listener is attached. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors: Propagate the CLI login timeout into the bundled Cloud SDK and swallow asynchronous browser-launch errors | ||
| - Final review findings are addressed with one behavioral regression test; CLI tests, contract checks, Go tests, Go vet, syntax checks, and affected TypeScript package typechecks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.