feat: add agent catalog/auth API and safer orchestrator switching#2309
feat: add agent catalog/auth API and safer orchestrator switching#2309nikhilachale wants to merge 24 commits into
Conversation
- Implemented AgentsController to handle /agents endpoint, returning a list of supported and installed agents. - Created agent inventory service to manage agent data and detect installed agents. - Updated ProjectSettingsForm to fetch and display agent information, including installed and supported agents. - Enhanced error handling for agent detection and orchestrator restarts. - Added tests for agent catalog and service to ensure correct functionality and error handling.
…flect changes - Added `AuthStatus` method to various agent plugins to check authorization status using CLI probes. - Introduced `authprobe` package to handle common CLI command checks for agent authorization. - Updated backend tests to include scenarios for authorized and unauthorized agents. - Modified frontend API schema to include `authorized` counts and `authStatus` for agents. - Enhanced `ProjectSettingsForm` to display authorized agents and their statuses, including prompts for login when necessary. - Adjusted agent selection logic to prioritize authorized agents and provide feedback for unauthorized or uninstalled agents.
…references from API and frontend
- Updated NewTaskDialog tests to increase timeout for async operations. - Modified ProjectSettingsForm tests to improve agent handling and validation messages. - Refactored ProjectSettingsForm component to streamline agent selection and validation logic. - Introduced new agent service to manage agent inventory and authentication status. - Improved Sidebar tests to ensure proper agent options are loaded and handled. - Enhanced SessionsBoard component by removing unused imports and optimizing state management. - Fixed Select component styling for better consistency in UI. - Added error handling for AO daemon readiness in ShellLayout.
…in session manager
- Implement local authentication status checks for PI, Qwen, and Vibe agents. - Introduce JSON-based authentication status retrieval for PI agents. - Add environment variable checks for Qwen agents and improve settings file parsing. - Enhance Vibe agent authentication with support for environment variables and session logs. - Update agent service to handle asynchronous probing for installed and authorized agents. - Modify session manager to support prompt delivery strategies based on agent capabilities. - Improve frontend agent selection UI with loading states and error handling. - Add tests for new authentication logic and session management features.
- Implement local authentication status checks for the Devin, Droid, Kiro, and other agents. - Add support for reading credentials from specific configuration files and environment variables. - Introduce new tests for various agents to ensure proper authentication status reporting. - Refactor existing authentication logic to improve clarity and maintainability. - Remove deprecated agent setup warnings from the SessionsBoard component in the frontend.
…pdate component props
|
@neversettle17-101 @illegalcall please review this |
- Deleted the RetireOrchestrator function and its associated error handling. - Removed tests related to orchestrator retirement and state management. - Simplified ProjectSettingsForm by eliminating orchestrator restart logic and related UI elements. - Updated API client mocks to reflect the removal of orchestrator-related functionality.
- Added agent refresh functionality in ProjectSettingsForm with UI updates for agent availability. - Implemented `refreshAgents` API call to fetch the latest agent catalog. - Updated agent selection logic to disable unavailable agents and show appropriate error messages. - Enhanced error handling in `apiErrorMessage` to include daemon error codes alongside messages. - Created new test cases for agent availability and error handling in Sidebar component. - Introduced `ResolveBinary` method for multiple agent adapters to standardize binary resolution. - Added new agent adapter files for various agents (e.g., Aider, Claude Code, etc.) to support binary resolution.
|
Agent adapters gained binary-resolution behavior across Agy, Aider, Amp, Auggie, AutoHand, Claude Code, Cline, Codex, Continue, Copilot, Crush, Cursor, Devin, Droid, Goose, Grok, Kilocode, Kimi, Kiro, OpenCode, Pi, Qwen, and Vibe. |
illegalcall
left a comment
illegalcall
left a comment
There was a problem hiding this comment.
I found a few issues that should be fixed before merging:
- P1: Preserve the no-resurrection marker cleanup
session_worktrees is used as the shutdown-restore marker. The intended flow is: shutdown writes the marker, next boot restores the session, then the marker is consumed/deleted.
In this PR, Kill marks a session terminated but no longer clears that stale marker. Example: AO shutdown saves proj-1, next boot restores it, the user later explicitly kills proj-1, and the next daemon boot sees the old marker and relaunches the killed session. Explicit kill intent must win.
Please restore marker cleanup on Kill and after RestoreAll consumes a marker, and keep the no-resurrection tests.
- P2: Return arrays, not
null, for the initial agent cache
On a fresh daemon before POST /agents/refresh, Installed and Authorized are nil slices. JSON encodes those as null, but the OpenAPI/generated TS contract says these fields are arrays.
Example response today can be:
{ "supported": [...], "installed": null, "authorized": null }Clients should receive:
{ "supported": [...], "installed": [], "authorized": [] }Please initialize/clone nil slices as empty slices so first-load clients always get arrays.
- P2: Make OpenCode binary resolution fail when absent
/agents/refresh treats a successful ResolveBinary as installed. OpenCode currently falls back to the bare string "opencode", so a machine without OpenCode can still report it as installed. Later, spawn does the real binary check and fails.
For catalog/install detection, ResolveBinary should only succeed when a real executable path is found; otherwise return ports.ErrAgentBinaryNotFound.
- P2: Avoid sending a real Continue prompt during auth refresh
Refreshing the catalog should be local/status-only. The Continue auth fallback runs cn -p hi, which is a prompt execution path, not an auth status check.
Example: opening project settings and refreshing agents could submit an actual model prompt, create local session/history, consume quota, or hang on provider/login state. If Continue has no safe local auth signal, return unknown rather than running a live prompt.
2 participants
Summary
This PR adds a daemon-backed agent catalog, exposes installed/authorized agent state to the frontend, and uses that data in project settings so users can choose worker/orchestrator agents more safely.
It also adds orchestrator replacement handling: when the saved orchestrator agent changes, AO starts the replacement first and only retires the previous orchestrator after the new one is up, so a failed replacement does not cause downtime.
A key caveat is that agent-auth/login flows can interfere with replacement startup. If switching agents triggers the agent’s own bootstrap path, the replacement may come up outside AO’s normal orchestrator initialization path and miss the AO orchestrator system prompt.
What Changed
Backend
Added agent inventory service for:
supported agents
installed agents
authorized agents
counts for each
Added optional AgentAuthChecker capability on adapters.
Added shared CLI auth probing helper for adapters with cheap local auth checks.
Added GET /api/v1/agents.
Extended registry inventory entries to carry adapter manifest metadata for user-facing labels.
Added orchestrator replacement flow in the session service:
spawn replacement first
retire previous orchestrator only after successful replacement
preserve previous orchestrator when replacement startup fails
Added backend tests for agent catalog, controller responses, session replacement behavior, and related project/service wiring.
Frontend
Regenerated API types for the new agents endpoint/DTOs.
Updated ProjectSettingsForm to:
load agent catalog from the daemon
show authorized agent options
handle installed-but-not-authorized states
surface orchestrator replacement pending state
allow retry once replacement is safe to perform
Added/updated tests for the new settings behavior.
aoagents/ReverbCode#276. extended version of this pr
closes #2310