fix(devtools-kit): guard state editor against undefined path traversal - #5
Open
arena-ai-coding-agent[bot] wants to merge 1 commit into
Open
fix(devtools-kit): guard state editor against undefined path traversal#5arena-ai-coding-agent[bot] wants to merge 1 commit into
arena-ai-coding-agent[bot] wants to merge 1 commit into
Conversation
When editing state from the component inspector (e.g. a Pinia store), the path used to locate the value may not exist on the target object. After traversing such a path, `StateEditor.set` did `this.refEditor.get(object)[field]` where `object` was `undefined`, throwing: `TypeError: this.refEditor.get(...) is undefined`. Stop the edit silently when the path does not resolve instead of throwing. Adds a regression test asserting a non-existing nested path does not throw. Closes vuejs#906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editing state from the component inspector (e.g. a Pinia store) throws an uncaught:
Cause
In
StateEditor.set(), the path used to locate the value may not exist on the target object. After traversing such a path,objectbecomesundefined, and the code then evaluates:which reads a property off
undefinedand throws aTypeError. This is reproducible when the inspector passes a path that the component proxy does not have (e.g. a Piniastatepath from the Components tab).Fix
Stop the edit gracefully when the path does not resolve, instead of throwing. An early
if (object == null) returnis added both inside the traversal loop and before the final field access. Legitimate edits are unaffected.Tests
Added a regression test asserting that editing via a non-existing nested path does not throw. The full suite passes (
86tests) along withtype-check,lint, andbuild.Closes vuejs#906