Skip to content

perf(mpi): remove the serial O(R·S²) protocol floor from HybridComm - #166

Draft
diagonal-hamiltonian wants to merge 3 commits into
mainfrom
perf/multinode-comm-scaling
Draft

perf(mpi): remove the serial O(R·S²) protocol floor from HybridComm#166
diagonal-hamiltonian wants to merge 3 commits into
mainfrom
perf/multinode-comm-scaling

docs(parallelism): 📝 document monoprop_COMM_PROFILE and the two-level…

69a7932
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 29, 2026 in 1m 33s

Annotations

Check warning on line 51 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find" that takes a range.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASR&open=AZ-tDxSCC20taTj0MASR&pullRequest=166

Check warning on line 450 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASI&open=AZ-tDxMiC20taTj0MASI&pullRequest=166

Check failure on line 90 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MAST&open=AZ-tDxSCC20taTj0MAST&pullRequest=166

Check failure on line 96 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASY&open=AZ-tDxSCC20taTj0MASY&pullRequest=166

Check failure on line 181 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASE&open=AZ-tDxMiC20taTj0MASE&pullRequest=166

Check warning on line 171 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 10 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASC&open=AZ-tDxMiC20taTj0MASC&pullRequest=166

Check failure on line 95 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASX&open=AZ-tDxSCC20taTj0MASX&pullRequest=166

Check failure on line 172 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASM&open=AZ-tDxMiC20taTj0MASM&pullRequest=166

Check warning on line 45 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this structure so it has no more than 20 fields, rather than the 34 it currently has.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MAR_&open=AZ-tDxMiC20taTj0MAR_&pullRequest=166

Check warning on line 503 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASG&open=AZ-tDxMiC20taTj0MASG&pullRequest=166

Check failure on line 97 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASZ&open=AZ-tDxSCC20taTj0MASZ&pullRequest=166

Check failure on line 175 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASN&open=AZ-tDxMiC20taTj0MASN&pullRequest=166

Check failure on line 91 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASU&open=AZ-tDxSCC20taTj0MASU&pullRequest=166

Check warning on line 69 in src/monoprop/detail/mpi/CommProfile.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tHDAdLJoACkbdBnNg&open=AZ-tHDAdLJoACkbdBnNg&pullRequest=166

Check warning on line 646 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASJ&open=AZ-tDxMiC20taTj0MASJ&pullRequest=166

Check failure on line 426 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASO&open=AZ-tDxMiC20taTj0MASO&pullRequest=166

Check warning on line 763 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASK&open=AZ-tDxMiC20taTj0MASK&pullRequest=166

Check failure on line 129 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASb&open=AZ-tDxSCC20taTj0MASb&pullRequest=166

Check failure on line 92 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASV&open=AZ-tDxSCC20taTj0MASV&pullRequest=166

Check warning on line 35 in src/monoprop/detail/mpi/CommProfile.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't mix public and private data members.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSaC20taTj0MASd&open=AZ-tDxSaC20taTj0MASd&pullRequest=166

Check warning on line 764 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASL&open=AZ-tDxMiC20taTj0MASL&pullRequest=166

Check warning on line 45 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 43 methods, which is greater than the 35 authorized. Split it into smaller classes.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASA&open=AZ-tDxMiC20taTj0MASA&pullRequest=166

Check warning on line 425 in src/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 10 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASF&open=AZ-tDxMiC20taTj0MASF&pullRequest=166

Check failure on line 139 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASc&open=AZ-tDxSCC20taTj0MASc&pullRequest=166

Check warning on line 89 in src/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASS&open=AZ-tDxSCC20taTj0MASS&pullRequest=166