Skip to content

MathUtils: declare fastATan2's Pi where its lambdas can use it #15949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Oct 14, 2026
Merged

MathUtils: declare fastATan2's Pi where its lambdas can use it #15949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Common/MathUtils/include/MathUtils/detail/trigonometric.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,11 @@ GPUhdi() constexpr T fastATan2(T y, T x)
// Average inaccuracy: 0.00048
// Max inaccuracy: 0.00084
// Speed: 6.2 times faster than atan2f()
constexpr T Pi = 3.1415926535897932384626433832795;

auto atan = [](T a) -> T {
// returns the arctan for the angular range [-Pi/4, Pi/4]
// the polynomial coefficients are taken from:
// https://stackoverflow.com/questions/42537957/fast-accurate-atan-arctan-approximation-algorithm
constexpr T Pi = 3.1415926535897932384626433832795;
constexpr T A = 0.0776509570923569;
constexpr T B = -0.287434475393028;
constexpr T C = ((Pi / 4) - A - B);
Expand All @@ -290,6 +289,7 @@ GPUhdi() constexpr T fastATan2(T y, T x)

auto atan2P = [atan](T yy, T xx) -> T {
// fast atan2(yy,xx) for the angular range [0,+Pi]
constexpr T Pi = 3.1415926535897932384626433832795;
constexpr T Pi025 = 1 * Pi / 4;
constexpr T Pi075 = 3 * Pi / 4;
const T x1 = xx + yy; // point p1 (x1,y1) = (xx,yy) - Pi/4
Expand Down
Loading