Skip to content

Fix Float16_t compatibility - #15950

Merged
ktf merged 1 commit into
AliceO2Group:devfrom
ktf:pr15950
Oct 14, 2026
Merged

ktf merged 1 commit into
AliceO2Group:devfrom
ktf:pr15950

Conversation

@ktf

@ktf ktf commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@ktf
ktf requested a review from davidrohr as a code owner October 12, 2026 22:20
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 2e44e3a at 2026-10-13 13:26:

## sw/BUILD/O2Physics-latest/log
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -a -v clang-diagnostic-error error-log.txt
++ grep -a ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/1634a68fb7905aad26b0c47c1a96781fb9a26f04/slc9_x86-64/o2checkcode/1.0-local22/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='FairCMakeModules safe_int Python-modules-list MPFR Alice-GRID-Utils double-conversion pytorch_cpuinfo googlebenchmark defaults-release date UUID json-c bz2 alibuild-recipe-tools ninja O2-customization CMake ninja-fortran'
+ echo 'FULL_BUILD_REQUIRES=FairCMakeModules safe_int Python-modules-list MPFR Alice-GRID-Utils double-conversion pytorch_cpuinfo googlebenchmark defaults-release date UUID json-c bz2 alibuild-recipe-tools ninja O2-customization CMake ninja-fortran'
FULL_BUILD_REQUIRES=FairCMakeModules safe_int Python-modules-list MPFR Alice-GRID-Utils double-conversion pytorch_cpuinfo googlebenchmark defaults-release date UUID json-c bz2 alibuild-recipe-tools ninja O2-customization CMake ninja-fortran
++ env
++ cut -f1 -d=
++ grep -v PKGREVISION
++ grep -v '^DEFAULT_'
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 14
+ REVISION_VALUE=14
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ '[' -z 14 ']'
+ echo 'FairCMakeModules safe_int Python-modules-list MPFR Alice-GRID-Utils double-conversion pytorch_cpuinfo googlebenchmark defaults-release date UUID json-c bz2 alibuild-recipe-tools ninja O2-customization CMake ninja-fortran'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
+ tr ' ' '\n'
+ grep -q '^LIBFFI$'
[0 more errors; see full log]

Full log here.

@davidrohr davidrohr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU: is missing in the name, I didn't look at the PR before :).

@ktf

ktf commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

Fair enough. ;-)

@ktf
ktf merged commit 257d60e into AliceO2Group:dev Oct 14, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants