Skip to content

[O2B-1556] Configure filtering model observability to set active filters to the url #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NarrowsProjects wants to merge 35 commits into
base: improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel
Choose a base branch
from

chore: rename pageIdentifiers to pageIdentifier

4a30d27
Select commit
Loading
Failed to load commit list.
Open

[O2B-1556] Configure filtering model observability to set active filters to the url #2142

chore: rename pageIdentifiers to pageIdentifier
4a30d27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 24, 2026 in 0s

45.92% (-0.09%) compared to 1f9af44

View this Pull Request on Codecov

45.92% (-0.09%) compared to 1f9af44

Details

Codecov Report

❌ Patch coverage is 0% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.92%. Comparing base (1f9af44) to head (4a30d27).

Files with missing lines Patch % Lines
...public/components/Filters/common/FilteringModel.js 0.00% 18 Missing ⚠️
lib/public/Model.js 0.00% 7 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 7 Missing ⚠️
...public/views/DataPasses/DataPassesOverviewModel.js 0.00% 6 Missing ⚠️
.../Environments/Overview/EnvironmentOverviewModel.js 0.00% 6 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 5 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 5 Missing ⚠️
...s/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js 0.00% 5 Missing ⚠️
...dOverview/AnchoredSimulationPassesOverviewModel.js 0.00% 5 Missing ⚠️
...rview/SimulationPassesPerLhcPeriodOverviewModel.js 0.00% 5 Missing ⚠️
... and 18 more
Additional details and impacted files 
@@                                                           Coverage Diff                                                           @@
##           improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel    #2142      +/-   ##
=======================================================================================================================================
- Coverage                                                                                                46.01%   45.92%   -0.09%     
=======================================================================================================================================
  Files                                                                                                     1036     1037       +1     
  Lines                                                                                                    17126    17153      +27     
  Branches                                                                                                  3110     3116       +6     
=======================================================================================================================================
- Hits                                                                                                      7881     7878       -3     
- Misses                                                                                                    9245     9275      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov