Repository navigation
[O2B-1640] Improve the UX of the run overview table - #2290
Merged
Merged
Conversation
- Run: run number with the definition and the quality below it - Timing: start, stop and duration - Context: LHC fill, LHC period and environment - Configuration: EPNs, FLPs, DCS and trigger - Merged columns are kept hidden to provide their filters and the export
…lpers Notable changes for developers: - New `getRunQualityColor` utility, used by the run details quality badge and the runs table quality button, to be reused by any display of the run quality. - `runActionsComponents` is extracted from the run number column of `runsActiveColumns`, to display the run's actions in other layouts than the button with dropdown. - `formatRunEnd` has a new `hideDateIfSameDayAs` option (inline only): the date of the end is hidden, but keeps its space, when it is the same day as the given timestamp, so the times stay aligned. - `detectorStyleClass` of `formatRunDetectorsInline` is exported.
Notable changes for users: - Run: the run number is a larger link, followed by a discreet caret opening the same actions as before. The definition and the quality of the run are displayed below it on one line, the quality in its color (good, bad, other). Each definition has its own neutral style (no color, as colors are reserved to states): PHYSICS dark badge, COSMICS outlined, TECHNICAL gray, SYNTHETIC dashed, CALIBRATION with a thick left bar (its calibration status is displayed below, in a compact badge) and COMMISSIONING dotted underline. An info icon next to the header of the column displays the legend of the definitions. - Timing: the labels are aligned and the time of the stop is aligned below the time of the start when the run stops the same day it started, the date being displayed when it is another day. - Context: narrower column. - Detectors and EOR reason are merged in one column: the detectors are wrapped on several lines instead of being truncated, with the EOR reasons below. Tags is its own column displaying the first tags followed by the number of remaining ones. - DCS is displayed in capital letters, as TRG. Notable changes for developers: - New `runsOverviewActiveColumns`, used by the run overview only. The columns merged into others are kept as hidden columns to provide their filters. - The estimation of the height of a row, used to compute the default number of rows, is updated. - New classes in `app.css`: `run-definition*`, `runs-calibration-status`, `runs-timing-label`, `bold`, `invisible` and `min-w-0`.
- Tests of the tags, EOR reasons, definition, quality, duration, start and stop, and run numbers use the elements of the new merged columns. - New tests for the legend of the run definitions, the hidden date of the stop of a run ending the same day it started, and the calibration status displayed below the definition of calibration runs. They were not run locally.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2290 +/- ##
==========================================
- Coverage 46.30% 46.17% -0.13%
==========================================
Files 1056 1059 +3
Lines 17445 17494 +49
Branches 3184 3210 +26
==========================================
Hits 8078 8078
- Misses 9367 9416 +49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The duration already has its own popover (warning on the missing trigger times), a second balloon around it hid it.
- The run overview displays 6 rows by default, as rows are taller. - The EOR reasons and the run number are read from the elements of the merged columns, including from the run details tests.
…the filters of the run overview Only the runs having EOR reasons display them, so the first page may not have any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
runsOverviewActiveColumns, used by the run overview only; the other runs tables keeprunsActiveColumns. The columns merged into others are kept as hidden columns to provide their filters.getRunQualityColor(reused byformatRunQualityand the runs table),runActionsComponentsextracted from the run number column,runDefinitionLegend, and ahideDateIfSameDayAsoption forformatRunEnd.app.css:run-definition*,runs-calibration-status,runs-timing-label,bold,invisible,min-w-0.#row<id>-run-number,-definition,-quality,-calibration-status,-start,-stop,-runDuration,-fillNumber,-lhcPeriod,-environmentId,-nEpns,-nFlps,-dcs,-triggerValue,-detectors,-eorReasons,-tags.Changes made to the database: