Skip to content

[PWGUD] simplified filter#15344

Closed
miedema-11 wants to merge 0 commit intoAliceO2Group:masterfrom
miedema-11:master
Closed

[PWGUD] simplified filter#15344
miedema-11 wants to merge 0 commit intoAliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11
Copy link
Copy Markdown
Contributor

@miedema-11 miedema-11 commented Mar 11, 2026

No description provided.

@github-actions github-actions Bot added the pwgud label Mar 11, 2026
@github-actions github-actions Bot changed the title simplified filter [PWGUD] simplified filter Mar 11, 2026
@amatyja amatyja enabled auto-merge (squash) March 11, 2026 10:00
@rolavick
Copy link
Copy Markdown
Collaborator

rolavick commented Mar 11, 2026

Hi,
This PR contains many old commits, which were already merged to master in previous PRs. Please, before making a new PR, make sure you rebased your fork to master branch. Thanks.

@miedema-11
Copy link
Copy Markdown
Contributor Author

miedema-11 commented Mar 11, 2026

Hi, This PR contains many old commits, which were already merged to master in previous PRs. Please, before making a new PR, make sure you rebased your fork to master branch. Thanks.

Thank you，I will pay attention to that

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Mar 11, 2026

Hi, This PR contains many old commits, which were already merged to master in previous PRs. Please, before making a new PR, make sure you rebased your fork to master branch. Thanks.

Indeed.
Also the code itself has plenty of lines commented out. Consider removing them or writing the code in a more configurable way.

auto-merge was automatically disabled March 13, 2026 16:48

Head branch was pushed to by a user without write access

@miedema-11 miedema-11 closed this Mar 13, 2026
auto-merge was automatically disabled March 13, 2026 16:48

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amatyja amatyja amatyja approved these changes

@alibuild alibuild Awaiting requested review from alibuild

@rolavick rolavick Awaiting requested review from rolavick

Assignees

No one assigned

Labels

pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miedema-11 @rolavick @vkucera @amatyja