Repository navigation
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
vkucera
marked this pull request as ready for review
October 21, 2026 16:48
amatyja
approved these changes
Oct 21, 2026
amatyja
left a comment
amatyja
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Vit, UD is ok.
vkucera
marked this pull request as draft
October 21, 2026 23:28
vkucera
force-pushed
the
cast-Tutorials
branch
2 times, most recently
from
October 22, 2026 17:03
949ea8b to
e0f1717
Compare
Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint). - Remove redundant casts. (`readability-redundant-casting`) - Remove `const_cast`. (`cppcoreguidelines-pro-type-const-cast`) - Replace C-style casts with `static_cast`. (`google-readability-casting`, cpplint: `readability/casting`) - Replace unsafe C-style casts with `dynamic_cast`. (`cppcoreguidelines-pro-type-cstyle-cast`) - Replace `static_cast` in downcasts with `dynamic_cast`. (`cppcoreguidelines-pro-type-static-cast-downcast`) - Replace `reinterpret_cast` with `static_cast` or `dynamic_cast`. (`cppcoreguidelines-pro-type-reinterpret-cast`) - Replace two-step casting through `void*` with `reinterpret_cast`. (`bugprone-casting-through-void`)
vkucera
force-pushed
the
cast-Tutorials
branch
from
October 26, 2026 14:34
e0f1717 to
5f06460
Compare
vkucera
marked this pull request as ready for review
October 26, 2026 15:24
Collaborator
Author
|
This PR is ready for review. |
amatyja
approved these changes
Oct 27, 2026
alcaliva
approved these changes
Oct 27, 2026
alcaliva
enabled auto-merge (squash)
October 27, 2026 11:01
dsekihat
approved these changes
Oct 27, 2026
vkucera
disabled auto-merge
October 29, 2026 23:26
vkucera
enabled auto-merge (squash)
October 29, 2026 23:26
Collaborator
Author
|
@jgrosseo, @victor-gonzalez, @zchochul Can you please review the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint).
readability-redundant-casting)const_cast. (cppcoreguidelines-pro-type-const-cast)static_cast. (google-readability-casting, cpplint:readability/casting)dynamic_cast. (cppcoreguidelines-pro-type-cstyle-cast)static_castin downcasts withdynamic_cast. (cppcoreguidelines-pro-type-static-cast-downcast)reinterpret_castwithstatic_castordynamic_cast. (cppcoreguidelines-pro-type-reinterpret-cast)void*withreinterpret_cast. (bugprone-casting-through-void)