feat(rubyllm): generate images via Context#paint behind use_ruby_llm flag - #799
Draft
fluxgravity wants to merge 1 commit into
Draft
fluxgravity wants to merge 1 commit into
fluxgravity wants to merge 1 commit into
Conversation
Contributor
Author
|
@strivedi183 do you have any feedback on this? I deferred to your #797 for the URL-based selection refactor. If that gets merged first, then this branch will likely need a minor rebase tweak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RubyLLM image generation behind the
use_ruby_llmflagCompletes the optional Phase 6 item skipped in #775:
AIBackend::RubyLLM.generate_imagewraps a keyedRubyLLM.context.paintinstead of inheriting the #780 delegation toAIBackend::OpenAI.generate_image. Same{ b64_json:, model: }contract and dispatch seam — flag off keeps the ruby-openai path byte-identical.Related PRs
use_ruby_llmflag.Known trade-off (deferred to #797)
A renamed OpenAI service keeps image gen flag-off but gets the "OpenAI API key not found" error flag-on. The URL-based reconciliation above resolves it.
Testing
bin/rails test: 912 runs, 0 failures; old-path tests untouched.images/generationsPOST confirmed.ruby-openai.