Skip to content

Feat/poke man - #3

Open
Prattbuw wants to merge 44 commits into
mainfrom
feat/poke-man
Open

Feat/poke man#3
Prattbuw wants to merge 44 commits into
mainfrom
feat/poke-man

Conversation

@Prattbuw

Copy link
Copy Markdown
Collaborator

@Poofjunior, the goal of this PR is to confirm that poke detection and the FSM works as expected in the test code. I have tested and confirmed their functionality. Therefore, please verify the following:

  • Pokes, represented as IR beam breaks, results in the poke detected flag to become true.
  • Confirm that FSM logic is correct -- state transitions and state durations match expectations.
  • Confirm that specified valve pins become energized and deenergized during the expected state.

Please let me know if you have any questions. Thanks!

@Prattbuw
Prattbuw requested a review from Poofjunior April 30, 2025 16:23
@Prattbuw

Copy link
Copy Markdown
Collaborator Author

Figures showing the results of the FSM -- particularly the timing and order that valves are energized given a detected poke. The following were the prescribed state durations:

  • Min poke time = 10 ms
  • Vacuum close time = 20 ms
  • Odor deliver time =10 ms
  • Odor transition time = 30 ms
  • Vacuum setup time = 20 ms
  • Final valve energized (while vacuum valve energized) = 110 ms
    delphi controller valve timing
    Delphi controller odor valve transitions

@Prattbuw

Copy link
Copy Markdown
Collaborator Author

Also, here is a test showing that a poke is not considered "detected" if the IR beam break is less than the 10 ms min poke time.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants