Skip to content

Trim verbose comments in b2-core, the UI and the eval examples - #247

Merged
samkeen merged 2 commits into
mainfrom
claude/reduce-code-comments-aq3h7g
Sep 27, 2026
Merged

samkeen merged 2 commits into
mainfrom
claude/reduce-code-comments-aq3h7g

Conversation

@samkeen

@samkeen samkeen commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Cut restated code, history and repeated rationale; shorten essay-style
doc comments to their intent plus the one non-obvious reason. Spec,
invariant and issue citations stay with the reasons they back.
Comment-only: no code changes.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01ArrZkgfz7HGyUuTadEUMKy

Cut restated code, history and repeated rationale; shorten essay-style
doc comments to their intent plus the one non-obvious reason. Spec,
invariant and issue citations stay with the reasons they back.
Comment-only: no code changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ArrZkgfz7HGyUuTadEUMKy
Same pass as the previous commit over b2-desktop, b2-llm, b2-embed/src,
b2-cli, the integration tests, the Makefile, CI workflow, scripts and
Cargo manifests. clap --help doc comments in args.rs and the Makefile's
make-help summaries are untouched. Comment-only: no code changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ArrZkgfz7HGyUuTadEUMKy
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 214 files, which is 114 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ed517d7c-b486-4192-ad1d-adaa86939869

📥 Commits

Reviewing files that changed from the base of the PR and between 3637de4 and 2edb2f7.

📒 Files selected for processing (214)
  • .github/workflows/ci.yml
  • Cargo.toml
  • Makefile
  • crates/b2-cli/Cargo.toml
  • crates/b2-cli/src/cancel.rs
  • crates/b2-cli/src/chat.rs
  • crates/b2-cli/src/error.rs
  • crates/b2-cli/src/logging.rs
  • crates/b2-cli/src/main.rs
  • crates/b2-cli/src/read.rs
  • crates/b2-cli/src/reindex.rs
  • crates/b2-cli/src/wiring.rs
  • crates/b2-cli/src/write.rs
  • crates/b2-cli/tests/cli.rs
  • crates/b2-core/Cargo.toml
  • crates/b2-core/src/add.rs
  • crates/b2-core/src/chat.rs
  • crates/b2-core/src/chunk.rs
  • crates/b2-core/src/db.rs
  • crates/b2-core/src/dirs.rs
  • crates/b2-core/src/discover.rs
  • crates/b2-core/src/embed.rs
  • crates/b2-core/src/error.rs
  • crates/b2-core/src/graph.rs
  • crates/b2-core/src/import.rs
  • crates/b2-core/src/ingest.rs
  • crates/b2-core/src/link.rs
  • crates/b2-core/src/llm.rs
  • crates/b2-core/src/mv.rs
  • crates/b2-core/src/note.rs
  • crates/b2-core/src/pathspec.rs
  • crates/b2-core/src/relation.rs
  • crates/b2-core/src/resource.rs
  • crates/b2-core/src/rm.rs
  • crates/b2-core/src/search.rs
  • crates/b2-core/src/snippet.rs
  • crates/b2-core/src/vault.rs
  • crates/b2-core/src/vault/chat.rs
  • crates/b2-core/src/vault/views.rs
  • crates/b2-core/tests/add.rs
  • crates/b2-core/tests/ask.rs
  • crates/b2-core/tests/cancel.rs
  • crates/b2-core/tests/chunks.rs
  • crates/b2-core/tests/common/mod.rs
  • crates/b2-core/tests/dirs.rs
  • crates/b2-core/tests/discover.rs
  • crates/b2-core/tests/discover_query_count.rs
  • crates/b2-core/tests/discover_surfacing.rs
  • crates/b2-core/tests/dry_run.rs
  • crates/b2-core/tests/embed.rs
  • crates/b2-core/tests/explain.rs
  • crates/b2-core/tests/explain_similar.rs
  • crates/b2-core/tests/frontmatter.rs
  • crates/b2-core/tests/fts_tokenizer.rs
  • crates/b2-core/tests/graph.rs
  • crates/b2-core/tests/hidden.rs
  • crates/b2-core/tests/import.rs
  • crates/b2-core/tests/ingest_resolver.rs
  • crates/b2-core/tests/list.rs
  • crates/b2-core/tests/logging.rs
  • crates/b2-core/tests/mv.rs
  • crates/b2-core/tests/project_embed.rs
  • crates/b2-core/tests/props.rs
  • crates/b2-core/tests/read.rs
  • crates/b2-core/tests/resources.rs
  • crates/b2-core/tests/rm_delete.rs
  • crates/b2-core/tests/roundtrip.rs
  • crates/b2-core/tests/search.rs
  • crates/b2-core/tests/substrate.rs
  • crates/b2-core/tests/vault.rs
  • crates/b2-core/tests/vector_pool_scale.rs
  • crates/b2-core/tests/why.rs
  • crates/b2-core/tests/write.rs
  • crates/b2-core/tests/write_frontmatter.rs
  • crates/b2-desktop/Cargo.toml
  • crates/b2-desktop/src/chat.rs
  • crates/b2-desktop/src/commands.rs
  • crates/b2-desktop/src/error.rs
  • crates/b2-desktop/src/keychain.rs
  • crates/b2-desktop/src/logging.rs
  • crates/b2-desktop/src/main.rs
  • crates/b2-desktop/src/menu.rs
  • crates/b2-desktop/src/slot.rs
  • crates/b2-desktop/src/state_file.rs
  • crates/b2-desktop/src/stats.rs
  • crates/b2-desktop/src/watch.rs
  • crates/b2-embed/Cargo.toml
  • crates/b2-embed/examples/calibrate.rs
  • crates/b2-embed/examples/common/mod.rs
  • crates/b2-embed/examples/eval/ablation.rs
  • crates/b2-embed/examples/eval/dense.rs
  • crates/b2-embed/examples/eval/discovery.rs
  • crates/b2-embed/examples/eval/evidence.rs
  • crates/b2-embed/examples/eval/fold.rs
  • crates/b2-embed/examples/eval/gate.rs
  • crates/b2-embed/examples/eval/instrument.rs
  • crates/b2-embed/examples/eval/labels.rs
  • crates/b2-embed/examples/eval/main.rs
  • crates/b2-embed/examples/eval/metrics.rs
  • crates/b2-embed/examples/eval/report.rs
  • crates/b2-embed/examples/eval/retrieval.rs
  • crates/b2-embed/examples/eval/tail.rs
  • crates/b2-embed/examples/stability.rs
  • crates/b2-embed/src/config.rs
  • crates/b2-embed/src/lib.rs
  • crates/b2-embed/src/model.rs
  • crates/b2-embed/src/provision.rs
  • crates/b2-llm/Cargo.toml
  • crates/b2-llm/examples/groundedness.rs
  • crates/b2-llm/src/lib.rs
  • crates/b2-llm/src/provider.rs
  • crates/b2-llm/src/setup.rs
  • crates/b2-llm/src/sse.rs
  • crates/b2-llm/tests/wire.rs
  • scripts/compare-embed-device.sh
  • scripts/doctor.sh
  • ui/scripts/gen-icons.ts
  • ui/src/api.ts
  • ui/src/bindings.test.ts
  • ui/src/bindings.ts
  • ui/src/chat.test.ts
  • ui/src/chat.ts
  • ui/src/chatview.ts
  • ui/src/cmdhold.test.ts
  • ui/src/cmdhold.ts
  • ui/src/copypath.test.ts
  • ui/src/copypath.ts
  • ui/src/coverage.test.ts
  • ui/src/coverage.ts
  • ui/src/droplink.test.ts
  • ui/src/droplink.ts
  • ui/src/editorcmds.test.ts
  • ui/src/editorcmds.ts
  • ui/src/editorkeys.test.ts
  • ui/src/editorkeys.ts
  • ui/src/embedlink.test.ts
  • ui/src/embedreminder.test.ts
  • ui/src/embedreminder.ts
  • ui/src/embeds.test.ts
  • ui/src/embeds.ts
  • ui/src/escape.ts
  • ui/src/explain.test.ts
  • ui/src/explain.ts
  • ui/src/explainview.ts
  • ui/src/findbar.ts
  • ui/src/findfield.test.ts
  • ui/src/findfield.ts
  • ui/src/format.test.ts
  • ui/src/format.ts
  • ui/src/graph.test.ts
  • ui/src/graph.ts
  • ui/src/graphview.ts
  • ui/src/highlight.test.ts
  • ui/src/highlight.ts
  • ui/src/hints.test.ts
  • ui/src/hints.ts
  • ui/src/icons.test.ts
  • ui/src/icons.ts
  • ui/src/importfiles.test.ts
  • ui/src/importfiles.ts
  • ui/src/keymap.test.ts
  • ui/src/keymap.ts
  • ui/src/keysview.ts
  • ui/src/linebreaks.test.ts
  • ui/src/links.test.ts
  • ui/src/links.ts
  • ui/src/list.test.ts
  • ui/src/list.ts
  • ui/src/livepreview.test.ts
  • ui/src/livepreview.ts
  • ui/src/main.ts
  • ui/src/markdown.ts
  • ui/src/menukeys.test.ts
  • ui/src/menukeys.ts
  • ui/src/move.test.ts
  • ui/src/move.ts
  • ui/src/newentry.test.ts
  • ui/src/newentry.ts
  • ui/src/panes.test.ts
  • ui/src/panes.ts
  • ui/src/paste.test.ts
  • ui/src/paste.ts
  • ui/src/reconcile.test.ts
  • ui/src/reconcile.ts
  • ui/src/recorder.test.ts
  • ui/src/recorder.ts
  • ui/src/render.test.ts
  • ui/src/render.ts
  • ui/src/resourceview.test.ts
  • ui/src/sanitize.test.ts
  • ui/src/sanitize.ts
  • ui/src/settingstabs.test.ts
  • ui/src/settingstabs.ts
  • ui/src/settingsview.ts
  • ui/src/shortcuts.test.ts
  • ui/src/shortcuts.ts
  • ui/src/sidenav.test.ts
  • ui/src/sidenav.ts
  • ui/src/state.ts
  • ui/src/strength.test.ts
  • ui/src/strength.ts
  • ui/src/theme.test.ts
  • ui/src/theme.ts
  • ui/src/treenav.test.ts
  • ui/src/treenav.ts
  • ui/src/turndown-plugin-gfm.d.ts
  • ui/src/types.ts
  • ui/src/widgets.ts
  • ui/src/wikicomplete.test.ts
  • ui/src/wikicomplete.ts
  • ui/src/zoom.test.ts
  • ui/src/zoom.ts
  • ui/style.css
  • ui/vite.config.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@samkeen
samkeen merged commit 4726e12 into main Sep 27, 2026
2 checks passed
@samkeen
samkeen deleted the claude/reduce-code-comments-aq3h7g branch September 27, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants