Remove object_storage_cluster_join_mode=local by ianton-ru · Pull Request #2228 · Altinity/ClickHouse

ianton-ru · 2026-08-18T10:06:18Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Remove object_storage_cluster_join_mode=local
Solved #1827

Improved default 'allow' behavior to work in swarm mode (when remote nodes do not have knowledge about tables).

Improved 'global' mode to work with old analyzer.

Documentation entry for user-facing changes

'local' is a legacy setting, behavior is the same as 'allow' after changes in upstream.

CI/CD Options

Exclude tests:

Regression jobs to run:

github-actions · 2026-08-18T10:07:22Z

Workflow [PR], commit [8a45e64]

ianton-ru · 2026-08-19T08:12:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 317db7ca6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-19T08:25:50Z

+    case ObjectStorageClusterJoinMode::LOCAL: // Legacy mode, equal to 'allow'
        return;


Preserve initiator-local joins for legacy local mode

When local is selected for an object-storage cluster query that joins a table existing only on the initiator—the scenario in tests/integration/test_s3_cluster/test.py::test_joins—returning here leaves the join in query_to_send, which is dispatched to every shard; for example, s0_1_0 cannot resolve the test's join_table. The previous LOCAL path stripped the join and forced FetchColumns so it ran on the initiator, whereas the new ALLOW behavior requests WithMergeableState; therefore existing local queries and the integration test fail rather than retaining compatible behavior.

Useful? React with 👍 / 👎.

Good point!

chatgpt-codex-connector · 2026-08-19T08:25:50Z

- `local` — Replaces the database and table in the subquery with local ones for the destination server (shard), leaving the normal `IN`/`JOIN.`
 - `global` — Replaces the `IN`/`JOIN` query with `GLOBAL IN`/`GLOBAL JOIN.` Right table executes first and is added to the secondary query as temporay table.
 - `allow` — Default value. Allows the use of these types of subqueries.
+- `local` — deprecated, legacy mode. The same as 'allow'.


Format the allow setting value as inline code

Replace the prose quotation 'allow' with the inline-code form `allow`. This is a literal ClickHouse setting value, and the repository requires such literals in documentation and comments to be wrapped in inline code.

AGENTS.md reference: AGENTS.md:L7-L7

Useful? React with 👍 / 👎.

…al tables Read the left object-storage table on cluster nodes and run `JOIN` / local `IN` on the initiator, including with `allow_experimental_analyzer=0`, so the right table does not need to exist on remote nodes. Keep `local` as a legacy alias of `allow`. Co-authored-by: Cursor <cursoragent@cursor.com>

…uster` The previous initiator-local rewrite duplicated planner/`removeJoin` logic. Call `extractLeftTableExpression`, `buildQueryToReadColumnsFromTableExpression`, and `removeJoin` instead. Co-authored-by: Cursor <cursoragent@cursor.com>

`GLOBAL IN` becomes `ASTTableIdentifier` `_subqueryN`, which `as<ASTIdentifier>` does not match, so remotes still received `GLOBAL IN (_subqueryN)` with analyzer disabled. Co-authored-by: Cursor <cursoragent@cursor.com>

Rewrite JOIN/IN to `GLOBAL JOIN`/`GLOBAL IN` in the old interpreter so `GlobalSubqueriesVisitor` can broadcast right tables, and send those external tables with the remote query. Co-authored-by: Cursor <cursoragent@cursor.com>

ianton-ru · 2026-08-19T16:19:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f10d74d7e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-19T16:52:07Z

+                && (rhs->as<ASTSubquery>() || rhs->as<ASTSelectQuery>() || rhs->as<ASTSelectWithUnionQuery>()
+                    || rhs->as<ASTIdentifier>() || rhs->as<ASTTableIdentifier>()))


Do not globalize expression aliases used as IN sets

When allow_experimental_analyzer=0 and object_storage_cluster_join_mode='global', a valid constant-set alias such as WITH (1, 2) AS vals ... WHERE key IN vals remains an ASTIdentifier; this branch converts it to globalIn, but GlobalSubqueriesMatcher::Data::addExternalStorage accepts only an ASTTableIdentifier, ASTSubquery, or ASTTableExpression, so analysis throws WRONG_GLOBAL_SUBQUERY instead of evaluating the set. Restrict this rewrite to actual table/subquery operands or resolve expression aliases first.

Useful? React with 👍 / 👎.

This reproduction does not fail. rewriteASTInFunctionsToGlobalIn runs before TreeRewriter. For WITH (1, 2) AS vals ... WHERE key IN vals, the RHS is still an ASTIdentifier at that point, so it is rewritten to globalIn. Then QueryNormalizer inlines the WITH alias to the constant tuple, and GlobalSubqueriesVisitor sees a literal/function RHS and converts globalIn back to in. addExternalStorage is not invoked, so there is no WRONG_GLOBAL_SUBQUERY.
The suggested fix — skip ASTIdentifier and only rewrite table/subquery operands — would be incorrect here. At rewrite time, IN join_table is also an ASTIdentifier; MarkTableIdentifiersVisitor has not run yet. Dropping that case would skip the rewrite that object_storage_cluster_join_mode=global needs for initiator-local tables.
No code change for this comment.

…torage_cluster_join_mode_local

ianton-ru · 2026-08-28T09:31:06Z

@blau-ai

blau-ai · 2026-08-28T09:34:30Z

CI triage for #2228

Verdict: 0 PR-caused failures. Three reds on this run — the PR aggregate gate plus two leaf checks — and both leaf failures are infra/flaky/pre-existing, unrelated to this change. All functional suites that ran (Fast test, all Stateless variants incl. cas s3 storage, builds amd/arm) are green on the substance.

Head SHA analyzed: 40e4fcd90298595f68b81d5ac94292e94acf8908 (from result_pr.json).

1. `Stateless tests (amd_binary, cas s3 storage, parallel)` — FAIL → flaky/infra, not PR-caused

Single failing test: 01880_materialized_view_to_table_type_check (Failed: 1, Passed: 11015).
The report's own auto-diagnosis: reran the test 48 times with the same randomized settings → 48 passed, 0 failed → "All reruns passed. The failure is not reproducible (likely a transient issue)." The result is tagged flaky.

Decisive log line:

Code: 499. DB::Exception: ... Poco::Exception. Code: 1000, e.code() = 111,
Connection refused ..., bucket test, key cas_s3/cas/ref_catalog, object size 311262. (S3_ERROR)
(query: CREATE TABLE test_input(id Int32) ENGINE=MergeTree() order by id;)

The failure is a transient S3 connection-refused during a plain CREATE TABLE ... ENGINE=MergeTree, i.e. the CAS/S3 test backend, not this PR's code path (object-storage-cluster JOIN rewriting).

This check is also flagged do_not_block_pipeline_on_failure: true, so it does not gate the pipeline.
Next step: safe to re-run; no code change needed. (The test exercises MergeTree table creation and is unrelated to object_storage_cluster_join_mode.)

2. `GrypeScanServer (-alpine) / Grype Scan` — FAIL → pre-existing/infra, not PR-caused

"Grype Scan Completed with 7 high/critical vulnerabilities" — this is a CVE scan of OS packages inside the built clickhouse-server:...-alpine image.
This PR changes only src/Core/{Settings.cpp,SettingsEnums.h}, src/Interpreters/InterpreterSelectQuery.cpp, src/Storages/IStorageCluster.{cpp,h} and four tests/integration/** files — no Dockerfiles, no contrib/ submodules, no dependency/package changes. A code change to JOIN handling cannot add or remove image-level CVEs, so this is a branch-wide/base-image condition, not a regression from this PR.
Next step: not actionable from this PR. If it must go green it needs a base-image / package bump (separate dependency PR), independent of this change.

3. `PR` — FAIL → aggregate gate only

This is the roll-up status of the child checks above; it carries no independent error. It clears once the two items above are re-run/waived.

Health check

The change is well-scoped and its functional CI is clean: Fast test (9313 passed), all Stateless variants including cas storage, cas s3 storage (the sole fail being the flaky S3 one above), s3 storage, debug parallel/sequential, and both amd & arm release/binary/debug builds are green. Nothing in the red checks points at the JOIN-mode rewrite logic.

One coverage note (not a failure): the integration suites this PR actually edits — test_s3_cluster, test_storage_iceberg_with_spark/test_cluster_joins.py, test_storage_iceberg_with_spark/test_remote_initiator.py, test_database_iceberg — show as skipped in this pipeline (sanitizer/arch tag exclusions), so the behavioral change to object_storage_cluster_join_mode isn't directly validated by this run. If you want that coverage before merge, it's worth kicking off the relevant integration job.

Bottom line: nothing to fix in the PR. Re-run the cas s3 storage stateless job to clear the flake; the Grype finding is a pre-existing image scan unrelated to this diff.

_{🤖 automated CI triage by @blau-ai — evidence from praktika result_pr.json for the head SHA.}

Selfeer · 2026-09-29T11:52:15Z

High: With the old analyzer, ORDER BY ALL on an allow or local cluster join crashes, and GROUP BY ALL aggregates on the shards before the join.

rewriteQueryForInitiatorLocalJoin calls removeJoin, which clears the ORDER BY and GROUP BY clauses but leaves order_by_all and group_by_all set. The non-join branch of the same function sets both flags to false. The join branch does not. IStorageCluster::read then builds the remote query with InterpreterSelectQuery, and TreeRewriter still honors the flags. expandOrderByAll dereferences orderBy(), which is now null (enable_order_by_all defaults to true), so SELECT ... FROM s3Cluster(...) JOIN local_table ORDER BY ALL with allow_experimental_analyzer = 0 crashes. GROUP BY ALL is expanded onto the stripped select list, so shards collapse duplicate left rows before the initiator joins and the joined row count is smaller than it should be.

Selfeer · 2026-09-29T12:15:52Z

`ORDER BY ALL` cluster join crash

Build: 26.6.2.20001.altinityantalya (40e4fcd90298595f68b81d5ac94292e94acf8908), log swarms/test.log.

Scenario /swarms/feature/order by all join/order by all with old analyzer failed. The same join through plain s3(), with allow_experimental_analyzer = 0, returned the expected rows. The following s3Cluster query segfaulted the server. GROUP BY ALL did not run, because the process was already dead.

Received signal Segmentation fault (11)
Address: 0x8. Access: read. Address not mapped to object.

Query:

SELECT t1.k, t1.v, t2.name
FROM s3Cluster('replicated_cluster', ...) AS t1
INNER JOIN order_by_all_dim_... AS t2 ON t1.k = t2.k
ORDER BY ALL
SETTINGS allow_experimental_analyzer = 0, object_storage_cluster_join_mode = 'allow'

query_id e60d7936-7b18-484e-8366-6f817e95d7b7. Settings recorded on the fatal line include allow_experimental_analyzer = false and object_storage_cluster_join_mode = 'allow'.

The fault is a read at address 0x8, which is a null object plus a small member offset. ClickHouse printed the symbolized stack starting at frame 2 (TreeRewriter::analyzeSelect); frame 1 is the signal handler and was not given a symbol. expandOrderByAll is inlined into analyzeSelect, so it has no frame of its own. The client then got Code: 32. ATTEMPT_TO_READ_AFTER_EOF while reading the response, because the server had already died.

Received signal Segmentation fault (11)
Address: 0x8. Access: read. Address not mapped to object.
Stack trace: 0x000000001ea64827 0x000000001e61ad9d 0x000000001e613a4c 0x000000001e60e454 0x000000001e60e219 0x000000001f20fced 0x000000001e625bad 0x000000001e6231f6 0x000000001e6633ab 0x000000001e6644fa 0x000000001eb20152 0x000000001eb1a9dd 0x000000002047f8a0 0x00000000204a66a4 0x0000000025fde687 0x0000000025fdeb26 0x0000000025f9be9c 0x0000000025f9a44f 0x0000766251d67ac3 0x0000766251df9850

2. DB::TreeRewriter::analyzeSelect(boost::intrusive_ptr<DB::IAST>&, DB::TreeRewriterResult&&, DB::SelectQueryOptions const&, std::vector<DB::TableWithColumnNamesAndTypes, std::allocator<DB::TableWithColumnNamesAndTypes>> const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::TableJoin>) const @ 0x000000001ea64827
3. DB::InterpreterSelectQuery::InterpreterSelectQuery(boost::intrusive_ptr<DB::IAST> const&, std::shared_ptr<DB::Context> const&, std::optional<DB::Pipe>, std::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::PreparedSets>)::$_0::operator()(bool) const @ 0x000000001e61ad9d
4. DB::InterpreterSelectQuery::InterpreterSelectQuery(boost::intrusive_ptr<DB::IAST> const&, std::shared_ptr<DB::Context> const&, std::optional<DB::Pipe>, std::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::PreparedSets>) @ 0x000000001e613a4c
5. DB::InterpreterSelectQuery::InterpreterSelectQuery(boost::intrusive_ptr<DB::IAST> const&, std::shared_ptr<DB::Context const> const&, std::optional<DB::Pipe>, std::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::PreparedSets>) @ 0x000000001e60e454
6. DB::InterpreterSelectQuery::InterpreterSelectQuery(boost::intrusive_ptr<DB::IAST> const&, std::shared_ptr<DB::Context const> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&) @ 0x000000001e60e219
7. DB::IStorageCluster::read(DB::QueryPlan&, std::vector<String, std::allocator<String>> const&, std::shared_ptr<DB::StorageSnapshot> const&, DB::SelectQueryInfo&, std::shared_ptr<DB::Context const>, DB::QueryProcessingStage::Enum, unsigned long, unsigned long) @ 0x000000001f20fced
8. DB::InterpreterSelectQuery::executeImpl(DB::QueryPlan&, std::optional<DB::Pipe>) @ 0x000000001e625bad
9. DB::InterpreterSelectQuery::buildQueryPlan(DB::QueryPlan&) @ 0x000000001e6231f6
10. DB::InterpreterSelectWithUnionQuery::buildQueryPlan(DB::QueryPlan&) @ 0x000000001e6633ab
11. DB::InterpreterSelectWithUnionQuery::execute() @ 0x000000001e6644fa
12. DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, std::unique_ptr<DB::ReadBuffer, std::default_delete<DB::ReadBuffer>>&, boost::intrusive_ptr<DB::IAST>&, std::shared_ptr<DB::ImplicitTransactionControlExecutor>, std::function<void ()>, DB::QueryResultDetails&) @ 0x000000001eb20152
13. DB::executeQuery(std::basic_string_view<char, std::char_traits<char>>, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum) @ 0x000000001eb1a9dd
14. DB::TCPHandler::runImpl() @ 0x000000002047f8a0
15. DB::TCPHandler::run() @ 0x00000000204a66a4
16. Poco::Net::TCPServerConnection::start() @ 0x0000000025fde687
17. Poco::Net::TCPServerDispatcher::run() @ 0x0000000025fdeb26
18. Poco::PooledThread::run() @ 0x0000000025f9be9c
19. Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000025f9a44f
20. ? @ 0x0000000000094ac3
21. ? @ 0x0000000000126850

`removeJoin` drops ORDER BY and GROUP BY but leaves the ALL flags set. With the old analyzer, re-analysis of that query null-dereferences `orderBy` for `ORDER BY ALL` and aggregates `GROUP BY ALL` on the shards before the initiator join. https: //github.com//pull/2228 Co-authored-by: Cursor <cursoragent@cursor.com>

…torage_cluster_join_mode_local Keep the initiator-local join rewrite, and still drop wrap predicates that are unsafe to run on remote nodes. Co-authored-by: Cursor <cursoragent@cursor.com>

ianton-ru · 2026-09-30T08:01:50Z

Crash should be fixed

Selfeer · 2026-10-07T12:45:56Z

Yep the crash is fixed:

Passing

✔ [ OK ] '/swarms/feature/order by all join/order by all with old analyzer' (6s 84ms)
✔ [ OK ] '/swarms/feature/order by all join' (6s 84ms)
✔ [ OK ] '/swarms/feature' (7s 105ms)
✔ [ OK ] '/swarms' (5m 3s)

…torage_cluster_join_mode_local

ianton-ru · 2026-10-19T12:13:27Z

Port on antalya-26.8 branch: #2609

Co-authored-by: Cursor <cursoragent@cursor.com>

…al join. Co-authored-by: Cursor <cursoragent@cursor.com>

…FULL` joins. Co-authored-by: Cursor <cursoragent@cursor.com>

…ps the clause. Co-authored-by: Cursor <cursoragent@cursor.com>

…zer. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

ianton-ru · 2026-10-21T17:38:29Z

@codex review

chatgpt-codex-connector · 2026-10-21T17:38:48Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-21T17:45:54.399343Z	`8a45e64`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a45e64fc0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-21T17:45:51Z

+                    ++i;
+            }
+        }
+        if (!removeJoin(*select_query, rewriter_result, context))


Clear DISTINCT before dispatching the raw scan

With the old analyzer, an initiator-local join such as SELECT DISTINCT count() FROM s3Cluster(...) JOIN local_dim ... reaches this new removeJoin path. removeJoin replaces the projection with the required left-side columns but preserves ASTSelectQuery::distinct, so each shard deduplicates those source rows before returning them and the initiator computes the aggregate from fewer rows, producing an incorrect count. Reset distinct on the stripped query so the remote FetchColumns stage returns the raw input rows.

Useful? React with 👍 / 👎.

No code change for this comment. removeJoin leaves select_query->distinct set, and the shard still returns every source row.

An initiator-local join is requested at FetchColumns. InterpreterSelectQuery calls executeDistinct only when to_stage > FetchColumns. The initiator applies DISTINCT to the joined result, so SELECT DISTINCT count() FROM s3Cluster(...) JOIN local_dim is not computed from a deduplicated scan.

chatgpt-codex-connector · 2026-10-21T17:45:51Z

+    select_query->setExpression(ASTSelectQuery::Expression::LIMIT_BY, {});
+    select_query->setExpression(ASTSelectQuery::Expression::LIMIT_OFFSET, {});
+    select_query->setExpression(ASTSelectQuery::Expression::LIMIT_LENGTH, {});


Reset LIMIT flags when removing LIMIT clauses

For an old-analyzer query without an explicit join but with an initiator-local IN subquery and ORDER BY ... LIMIT ... WITH TIES, the no-join rewrite removes ORDER BY and these lines remove the LIMIT nodes, but limit_with_ties remains true. Reanalysis in IStorageCluster::read then throws LIMIT WITH TIES without ORDER BY; similarly, LIMIT ... BY ALL leaves limit_by_all set after its clause is removed. Reset both modifier flags together with the corresponding expressions.

Useful? React with 👍 / 👎.

No code change for this comment. The non-join rewrite leaves limit_with_ties and limit_by_all set after it removes ORDER BY and LIMIT. removeJoin already clears both flags on the join path. Neither failure described here is reached.

LIMIT WITH TIES without ORDER BY is thrown from executeLimit, inside the same to_stage > FetchColumns block. Formatting prints WITH TIES only when limitLength is present, so the query text sent to the shard does not contain it.

LIMIT BY ALL is rejected by TreeRewriter for every old-analyzer query, including the original one, before this rewrite runs. A query that reaches the strip does not have that flag set.

Remove object_storage_cluster_join_mode=local

317db7c

ianton-ru added antalya port-antalya PRs to be ported to all new Antalya releases antalya-26.6 labels Aug 18, 2026

ianton-ru marked this pull request as ready for review August 19, 2026 08:03

chatgpt-codex-connector Bot reviewed Aug 19, 2026

View reviewed changes

ianton-ru marked this pull request as draft August 19, 2026 10:06

ianton-ru and others added 4 commits August 19, 2026 16:01

chatgpt-codex-connector Bot reviewed Aug 19, 2026

View reviewed changes

Merge branch 'antalya-26.6' into feature/antalya-26.6/remove_object_s…

40e4fcd

…torage_cluster_join_mode_local

ianton-ru marked this pull request as ready for review August 28, 2026 09:38

ianton-ru and others added 2 commits September 29, 2026 18:58

Merge branch 'antalya-26.6' into feature/antalya-26.6/remove_object_s…

0f70f78

…torage_cluster_join_mode_local Keep the initiator-local join rewrite, and still drop wrap predicates that are unsafe to run on remote nodes. Co-authored-by: Cursor <cursoragent@cursor.com>

Selfeer added the verified Approved for release label Oct 7, 2026

Merge branch 'antalya-26.6' into feature/antalya-26.6/remove_object_s…

2222452

…torage_cluster_join_mode_local

ianton-ru mentioned this pull request Oct 19, 2026

Make object_storage_cluster_join_mode=allow keep initiator-local joins #2609

Open

10 of 31 tasks

ianton-ru removed the port-antalya PRs to be ported to all new Antalya releases label Oct 19, 2026

zvonand mentioned this pull request Oct 20, 2026

Port graph for antalya-26.8 #2322

Open

56 tasks done

ianton-ru and others added 7 commits October 21, 2026 18:37

Keep old-analyzer RIGHT and FULL joins on the initiator.

076a4f1

Co-authored-by: Cursor <cursoragent@cursor.com>

Send the stripped query when a remote initiator runs an initiator-loc…

58e7683

…al join. Co-authored-by: Cursor <cursoragent@cursor.com>

Do not push left-table predicates under initiator-local RIGHT and `…

7a3c2b7

…FULL` joins. Co-authored-by: Cursor <cursoragent@cursor.com>

Clear GROUP BY modifiers when an initiator-local IN subquery stri…

f6c387f

…ps the clause. Co-authored-by: Cursor <cursoragent@cursor.com>

Treat a column-less subquery table as initiator-local under the analy…

b31e327

…zer. Co-authored-by: Cursor <cursoragent@cursor.com>

Strip an ordinary join that follows ARRAY JOIN from the shard query.

d626fdd

Co-authored-by: Cursor <cursoragent@cursor.com>

Keep PASTE joins on the initiator.

8a45e64

Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector Bot reviewed Oct 21, 2026

View reviewed changes

		case ObjectStorageClusterJoinMode::LOCAL: // Legacy mode, equal to 'allow'
		return;

		&& (rhs->as<ASTSubquery>() \|\| rhs->as<ASTSelectQuery>() \|\| rhs->as<ASTSelectWithUnionQuery>()
		\|\| rhs->as<ASTIdentifier>() \|\| rhs->as<ASTTableIdentifier>()))

Conversation

ianton-ru commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI/CD Options

Exclude tests:

Regression jobs to run:

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianton-ru commented Aug 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru commented Aug 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru commented Aug 28, 2026

Uh oh!

blau-ai commented Aug 28, 2026

CI triage for #2228

1. Stateless tests (amd_binary, cas s3 storage, parallel) — FAIL → flaky/infra, not PR-caused

2. GrypeScanServer (-alpine) / Grype Scan — FAIL → pre-existing/infra, not PR-caused

3. PR — FAIL → aggregate gate only

Health check

Uh oh!

Selfeer commented Sep 29, 2026

Uh oh!

Selfeer commented Sep 29, 2026

ORDER BY ALL cluster join crash

Uh oh!

ianton-ru commented Sep 30, 2026

Uh oh!

Selfeer commented Oct 7, 2026

Uh oh!

ianton-ru commented Oct 19, 2026

Uh oh!

ianton-ru commented Oct 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru Oct 21, 2026

ianton-ru commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading

1. `Stateless tests (amd_binary, cas s3 storage, parallel)` — FAIL → flaky/infra, not PR-caused

2. `GrypeScanServer (-alpine) / Grype Scan` — FAIL → pre-existing/infra, not PR-caused

3. `PR` — FAIL → aggregate gate only

`ORDER BY ALL` cluster join crash

chatgpt-codex-connector Bot commented Oct 21, 2026 •

edited

Loading