Skip to content

Stable 25.3: Fix crash reading Distributed view with old analyzer - #2465

Open
mkmkme wants to merge 1 commit into
releases/25.3.14from
mkmkme/stable-25.3/analyzer-crash
Open

mkmkme wants to merge 1 commit into
releases/25.3.14from
mkmkme/stable-25.3/analyzer-crash

Conversation

@mkmkme

@mkmkme mkmkme commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Keep the analyzer disabled in InterpreterSelectQuery after applying a stored SELECT's SETTINGS clause. This prevents StorageDistributed from taking its query-tree path without a planner context when an old-analyzer query reads a view with enable_analyzer = 1. Add a regression test for both analyzer modes and local and remote Distributed reads.

Adapt the settings access to the 25.3 API.

Forward-port of #2448.
(cherry picked from commit 59bd09d)

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix a possible crash when querying the view over Distributed with enable_analyzer=0

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

Keep the analyzer disabled in InterpreterSelectQuery after applying a
stored SELECT's SETTINGS clause. This prevents StorageDistributed from
taking its query-tree path without a planner context when an old-analyzer
query reads a view with enable_analyzer = 1. Add a regression test for
both analyzer modes and local and remote Distributed reads.

Adapt the settings access to the 25.3 API.

Forward-port of #2448.
(cherry picked from commit 59bd09d)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant