Repository navigation
Check failed
There is one commit incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 454ce36 | Make object_storage_cluster_join_mode=allow keep... |
Skipped: sign-off not required for members |
| 🟢 | 86b8586 | Keep old-analyzer RIGHT and FULL joins on the ... |
Skipped: sign-off not required for members |
| 🟢 | 2f934a8 | Send the stripped query when a remote initiator ru... | Skipped: sign-off not required for members |
| 🟢 | 25437aa | Do not push left-table predicates under initiator-... | Skipped: sign-off not required for members |
| 🟢 | 11ba8ee | Clear GROUP BY modifiers when an initiator-local... |
Skipped: sign-off not required for members |
| 🟢 | 91c56bb | Treat a column-less subquery table as initiator-lo... | Skipped: sign-off not required for members |
| 🟢 | 87c2d9a | Shrink the initiator-local join fixes. | Skipped: sign-off not required for members |
| 🟢 | c6d4d54 | Keep PREWHERE on the left scan of an initiator-l... |
Skipped: sign-off not required for members |
| 🟢 | 88e9e0c | Strip an ordinary join that follows ARRAY JOIN f... |
Skipped: sign-off not required for members |
| 🟢 | 82e50da | Keep PASTE joins on the initiator. |
Skipped: sign-off not required for members |
| 🔴 | ac820e2 | Move PREWHERE after the JOIN in 05391 to fix the s... | Sign-off not found |
| 🟢 | dbdae80 | Do not wrap query_info.query in place when sendi... |
Skipped: sign-off not required for members |
| 🟢 | 07395ad | Use Parquet in 05391 so the S3 storage supports ... |
Skipped: sign-off not required for members |
| 🟢 | 2a081d6 | Pin serialize_query_plan = 0 in the analyzer que... |
Skipped: sign-off not required for members |
| 🟢 | ef1de7c | Merge branch 'antalya-26.8' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~15 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/antalya-26.8/remove-object-storage-cluster-join-mode-local